Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Timur Tabi
Anton Vorontsov wrote: > This patch fixes various badnesses like this for all interrupt > controllers: ... > > Signed-off-by: Anton Vorontsov > --- Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing lis

Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Timur Tabi
Anton Vorontsov wrote: > That's the main point of this patch (as subject says). Yes, I see that now. :-) > You seem to be looking into an outdated kernel. ;-) IIRC, the > first caller of kzalloc() in init_IRQ() path appeared in Yes, you're right. -- Timur Tabi Linux kernel developer at Frees

Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Anton Vorontsov
On Wed, Jul 01, 2009 at 04:25:22PM -0500, Kumar Gala wrote: > > On Jul 1, 2009, at 3:59 PM, Anton Vorontsov wrote: > > >qe_ic is in the same boat, just as every other PIC controller. Heh.. > >doing some 'grep alloc_bootmem', it seems that there are pretty > >much offenders. Let's fix them? > > >

Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Anton Vorontsov
On Wed, Jul 01, 2009 at 04:13:43PM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > > diff --git a/arch/powerpc/sysdev/qe_lib/qe_ic.c > > b/arch/powerpc/sysdev/qe_lib/qe_ic.c > > index 63cdf98..074905c 100644 > > --- a/arch/powerpc/sysdev/qe_lib/qe_ic.c > > +++ b/arch/powerpc/sysdev/qe_lib/q

Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Kumar Gala
On Jul 1, 2009, at 3:59 PM, Anton Vorontsov wrote: qe_ic is in the same boat, just as every other PIC controller. Heh.. doing some 'grep alloc_bootmem', it seems that there are pretty much offenders. Let's fix them? arch/powerpc/platforms/82xx/pq2ads-pci-pic.c |2 +- arch/powerpc/sysdev/ipi

Re: [PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Timur Tabi
Anton Vorontsov wrote: > diff --git a/arch/powerpc/sysdev/qe_lib/qe_ic.c > b/arch/powerpc/sysdev/qe_lib/qe_ic.c > index 63cdf98..074905c 100644 > --- a/arch/powerpc/sysdev/qe_lib/qe_ic.c > +++ b/arch/powerpc/sysdev/qe_lib/qe_ic.c > @@ -333,12 +333,10 @@ void __init qe_ic_init(struct device_node *

[PATCH] powerpc: Don't use alloc_bootmem() in init_IRQ() path

2009-07-01 Thread Anton Vorontsov
This patch fixes various badnesses like this for all interrupt controllers: [ cut here ] Badness at c04db9dc [verbose debug info unavailable] NIP: c04db9dc LR: c04db9ac CTR: REGS: c053de30 TRAP: 0700 Not tainted (2.6.31-rc1-00432-ge69b2b5-dirty) MSR: 00021000