Re: [PATCH] powerpc: Don't clear larx reservation on system call exit

2010-02-14 Thread Benjamin Herrenschmidt
On Mon, 2010-02-15 at 15:06 +1100, Anton Blanchard wrote: > > Yeah that was my primary concern. Right now these things fail 100%, so > no one is relying on it. The worry is if people start writing their own > crazy low level system call + locking stubs that might work most of the > time (if we rem

Re: [PATCH] powerpc: Don't clear larx reservation on system call exit

2010-02-14 Thread Anton Blanchard
Hi Ben, > Well, the main issue here is leaking kernel reservations into userspace, > and thus the question of whether it is a big deal or not. There's also > an issue I can see with signals. > > The risk with kernel reservations leaking into userspace is a problem on > some processors that do n

Re: [PATCH] powerpc: Don't clear larx reservation on system call exit

2010-02-14 Thread Benjamin Herrenschmidt
On Mon, 2010-02-15 at 12:40 +1100, Anton Blanchard wrote: > Right now we clear the larx reservation on every system call exit. No code > should exist that tries to make use of larx/stcx across a system call (because > it would fail 100% of the time). > > We could continue to play it safe but syste

[PATCH] powerpc: Don't clear larx reservation on system call exit

2010-02-14 Thread Anton Blanchard
Right now we clear the larx reservation on every system call exit. No code should exist that tries to make use of larx/stcx across a system call (because it would fail 100% of the time). We could continue to play it safe but system call latency affects so many workloads. In the past we have alrea