Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Benjamin Herrenschmidt
On Mon, 2011-11-28 at 10:04 -0600, Kumar Gala wrote: > > +#ifndef CONFIG_BOOKE > > + {MSR_RI,"RI"}, > > We have 'RI' on some BOOKE so lets allow for it to be decoded > > > + {MSR_LE,"LE"}, > > +#endif > > {0, NULL} > > }; > > Since you're fixing this can you

Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Scott Wood
On 11/28/2011 02:12 PM, Josh Boyer wrote: > On Mon, Nov 28, 2011 at 3:04 PM, Scott Wood wrote: >> On 11/28/2011 01:46 PM, Josh Boyer wrote: >>> Could introduce BOOK3E_32 to cover cases like this. >> >> Why _32? These bits apply to 64-bit as well. MSR_CM is only for 64-bit. > > Because CONFIG_BO

Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Josh Boyer
On Mon, Nov 28, 2011 at 3:04 PM, Scott Wood wrote: > On 11/28/2011 01:46 PM, Josh Boyer wrote: >> On Mon, Nov 28, 2011 at 2:30 PM, Scott Wood wrote: >>> On 11/28/2011 10:23 AM, Josh Boyer wrote: On Mon, Nov 28, 2011 at 11:04 AM, Kumar Gala wrote: > > Since you're fixing this c

Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Scott Wood
On 11/28/2011 01:46 PM, Josh Boyer wrote: > On Mon, Nov 28, 2011 at 2:30 PM, Scott Wood wrote: >> On 11/28/2011 10:23 AM, Josh Boyer wrote: >>> On Mon, Nov 28, 2011 at 11:04 AM, Kumar Gala >>> wrote: Since you're fixing this can you add the following for CONFIG_BOOKE: MSR_GS,

Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Josh Boyer
On Mon, Nov 28, 2011 at 2:30 PM, Scott Wood wrote: > On 11/28/2011 10:23 AM, Josh Boyer wrote: >> On Mon, Nov 28, 2011 at 11:04 AM, Kumar Gala >> wrote: >>> >>> Since you're fixing this can you add the following for CONFIG_BOOKE: >>> >>> MSR_GS, MSR_UCLE, MSR_PMM, MSR_CM >> >> Those don't exist

Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Scott Wood
On 11/28/2011 10:23 AM, Josh Boyer wrote: > On Mon, Nov 28, 2011 at 11:04 AM, Kumar Gala > wrote: >> >> Since you're fixing this can you add the following for CONFIG_BOOKE: >> >> MSR_GS, MSR_UCLE, MSR_PMM, MSR_CM > > Those don't exist on 4xx, so CONFIG_BOOKE doesn't seem appropriate. They're de

Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Josh Boyer
On Mon, Nov 28, 2011 at 11:04 AM, Kumar Gala wrote: > > On Nov 24, 2011, at 11:35 PM, Anton Blanchard wrote: > >> >> On a 64bit book3s machine I have an oops from a system reset that >> claims the book3e CE bit was set: >> >> MSR: 80021032  CR: 24004082  XER: 0010 >> >> On a book3s ma

Re: [PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-28 Thread Kumar Gala
On Nov 24, 2011, at 11:35 PM, Anton Blanchard wrote: > > On a 64bit book3s machine I have an oops from a system reset that > claims the book3e CE bit was set: > > MSR: 80021032 CR: 24004082 XER: 0010 > > On a book3s machine system reset sets IBM bit 46 and 47 depending on > the

[PATCH] powerpc: Decode correct MSR bits in oops output

2011-11-24 Thread Anton Blanchard
On a 64bit book3s machine I have an oops from a system reset that claims the book3e CE bit was set: MSR: 80021032 CR: 24004082 XER: 0010 On a book3s machine system reset sets IBM bit 46 and 47 depending on the power saving mode. Separate the definitions by type and for completenes