Re: [PATCH] powerpc: Avoid integer overflow in page_is_ram()

2008-09-15 Thread Roland Dreier
> > #ifndef CONFIG_PPC64 /* XXX for now */ > > - return paddr < __pa(high_memory); > > + return pfn < max_pfn; > > #else > > + unsigned long paddr = (pfn << PAGE_SHIFT); > > seems like this could be a phys_addr_t Yes, it could I guess, but that would be an unrelated change, and I'

Re: [PATCH] powerpc: Avoid integer overflow in page_is_ram()

2008-09-15 Thread Kumar Gala
On Sep 15, 2008, at 3:43 PM, Roland Dreier wrote: Commit 8b150478 ("ppc: make phys_mem_access_prot() work with pfns instead of addresses") fixed page_is_ram() in arch/ppc to avoid overflow for addresses above 4G on 32-bit kernels. However arch/powerpc's page_is_ram() is missing the same fix

[PATCH] powerpc: Avoid integer overflow in page_is_ram()

2008-09-15 Thread Roland Dreier
Commit 8b150478 ("ppc: make phys_mem_access_prot() work with pfns instead of addresses") fixed page_is_ram() in arch/ppc to avoid overflow for addresses above 4G on 32-bit kernels. However arch/powerpc's page_is_ram() is missing the same fix -- it computes a physical address by doing pfn << PAGE_S