Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-14 Thread panxinhui
在 2017/2/15 上午1:35, Guilherme G. Piccoli 写道: > On 14/02/2017 01:58, Pan Xinhui wrote: >> >> >> 在 2017/2/14 10:35, Nicholas Piggin 写道: >>> On Mon, 13 Feb 2017 19:00:42 -0200 >>> >>> xmon state changing after the first sysrq+x violates principle of least >>> astonishment, so I think that should be

Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-14 Thread Michael Ellerman
"Guilherme G. Piccoli" writes: > On 14/02/2017 01:58, Pan Xinhui wrote: >> 在 2017/2/14 10:35, Nicholas Piggin 写道: >>> On Mon, 13 Feb 2017 19:00:42 -0200 >>> >>> xmon state changing after the first sysrq+x violates principle of least >>> astonishment, so I think that should be fixed. >>> >> hi, Nic

Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-14 Thread Guilherme G. Piccoli
On 14/02/2017 09:37, Michael Ellerman wrote: > "Guilherme G. Piccoli" writes: > >> Currently the xmon debugger is set only via kernel boot command-line. >> It's disabled by default, and can be enabled with "xmon=on" on the >> command-line. Also, xmon may be accessed via sysrq mechanism, but once

Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-14 Thread Guilherme G. Piccoli
On 14/02/2017 01:58, Pan Xinhui wrote: > > > 在 2017/2/14 10:35, Nicholas Piggin 写道: >> On Mon, 13 Feb 2017 19:00:42 -0200 >> >> xmon state changing after the first sysrq+x violates principle of least >> astonishment, so I think that should be fixed. >> > hi, Nick > yes, as long as xmon is disable

Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-14 Thread Michael Ellerman
Pan Xinhui writes: > 在 2017/2/14 10:35, Nicholas Piggin 写道: >> On Mon, 13 Feb 2017 19:00:42 -0200 >> "Guilherme G. Piccoli" wrote: >>> * I had this patch partially done for some time, and after a discussion >>> at the kernel slack channel latest week, I decided to rebase and fix >>> some remainin

Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-14 Thread Michael Ellerman
"Guilherme G. Piccoli" writes: > Currently the xmon debugger is set only via kernel boot command-line. > It's disabled by default, and can be enabled with "xmon=on" on the > command-line. Also, xmon may be accessed via sysrq mechanism, but once > we enter xmon via sysrq, it's kept enabled until

Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-13 Thread Pan Xinhui
在 2017/2/14 10:35, Nicholas Piggin 写道: On Mon, 13 Feb 2017 19:00:42 -0200 "Guilherme G. Piccoli" wrote: Currently the xmon debugger is set only via kernel boot command-line. It's disabled by default, and can be enabled with "xmon=on" on the command-line. Also, xmon may be accessed via sysrq

Re: [PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-13 Thread Nicholas Piggin
On Mon, 13 Feb 2017 19:00:42 -0200 "Guilherme G. Piccoli" wrote: > Currently the xmon debugger is set only via kernel boot command-line. > It's disabled by default, and can be enabled with "xmon=on" on the > command-line. Also, xmon may be accessed via sysrq mechanism, but once > we enter xmon vi

[PATCH] powerpc/xmon: add debugfs entry for xmon

2017-02-13 Thread Guilherme G. Piccoli
Currently the xmon debugger is set only via kernel boot command-line. It's disabled by default, and can be enabled with "xmon=on" on the command-line. Also, xmon may be accessed via sysrq mechanism, but once we enter xmon via sysrq, it's kept enabled until system is rebooted, even if we exit the