Re: [PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom

2024-09-30 Thread Michael Ellerman
On Wed, 25 Sep 2024 19:50:22 +0200, Jason A. Donenfeld wrote: > For gettimeofday, -ffixed-r30 was passed to work around a bug in Go > code, where the vDSO trampoline forgot to save and restore this register > across function calls. But Go requires a different trampoline for every > call, and there'

Re: [PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom

2024-09-25 Thread Jason A. Donenfeld
On Wed, Sep 25, 2024 at 08:48:31PM +0200, Christophe Leroy wrote: > > > Le 25/09/2024 à 20:38, Jason A. Donenfeld a écrit : > > On Wed, Sep 25, 2024 at 07:50:22PM +0200, Jason A. Donenfeld wrote: > >> For gettimeofday, -ffixed-r30 was passed to work around a bug in Go > >> code, where the vDSO tr

Re: [PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom

2024-09-25 Thread Christophe Leroy
Le 25/09/2024 à 20:38, Jason A. Donenfeld a écrit : On Wed, Sep 25, 2024 at 07:50:22PM +0200, Jason A. Donenfeld wrote: For gettimeofday, -ffixed-r30 was passed to work around a bug in Go code, where the vDSO trampoline forgot to save and restore this register across function calls. But Go re

Re: [PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom

2024-09-25 Thread Jason A. Donenfeld
On Wed, Sep 25, 2024 at 07:50:22PM +0200, Jason A. Donenfeld wrote: > For gettimeofday, -ffixed-r30 was passed to work around a bug in Go > code, where the vDSO trampoline forgot to save and restore this register > across function calls. But Go requires a different trampoline for every > call, and

[PATCH] powerpc/vdso: allow r30 in vDSO code generation of getrandom

2024-09-25 Thread Jason A. Donenfeld
For gettimeofday, -ffixed-r30 was passed to work around a bug in Go code, where the vDSO trampoline forgot to save and restore this register across function calls. But Go requires a different trampoline for every call, and there's no reason that new Go code needs to be broken and add more bugs. So