rpc/usb: fix issue of CPU halt when missing
> USB PHY clock
>
>
> > > > + if (!(in_be32(non_ehci + FSL_SOC_USB_CTRL) &
> > > > +CTRL_PHY_CLK_VALID))
> > > {
> > > > + printk(KERN_WARNING "fsl-ehci: USB PHY clock
> > > + if (!(in_be32(non_ehci + FSL_SOC_USB_CTRL) & CTRL_PHY_CLK_VALID))
> > {
> > > + printk(KERN_WARNING "fsl-ehci: USB PHY clock invalid\n");
> > > + return -1;
> >
> > Please return a proper error code. -ENODEV ?
>
> [Shengzhou] Ok, updated in v2, thanks.
> >
Note that I ju
> -Original Message-
> From: Pavan Kondeti [mailto:pkond...@codeaurora.org]
> Sent: Wednesday, February 01, 2012 6:11 PM
> To: Liu Shengzhou-B36685
> Cc: linux-...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] powerpc/usb: fix issue of CPU halt
On 2/1/2012 2:50 PM, Shengzhou Liu wrote:
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index b556a72..834237e 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -239,7 +239,7 @@ static void ehci_fsl_setup_phy(struct ehci_hcd *ehci,
>
when missing USB PHY clock, kernel booting up will halt during USB
initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid
CPU hang in this case.
Signed-off-by: Shengzhou Liu
---
drivers/usb/host/ehci-fsl.c | 11 +--
drivers/usb/host/ehci-fsl.h |1 +
2 files changed, 10 i
