Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-07 Thread Liu Gang
Hi, Kumar, On Tue, 2012-03-06 at 11:46 -0600, Kumar Gala wrote: > How about a struct instead: > > struct rmu_dmsg { > u16 dummy; > u16 tid; > u16 sid; > u16 info; > }; > > struct rmu_dmsg *dmsg = fsl_dbell->dbell_ring.virt + > (in_be32(&fsl_dbell->d

Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-06 Thread Kumar Gala
On Mar 5, 2012, at 8:20 AM, Liu Gang wrote: > Hi, Kumar, > > On Fri, 2012-03-02 at 09:11 -0600, Kumar Gala wrote: >>> diff --git a/arch/powerpc/sysdev/fsl_rmu.c b/arch/powerpc/sysdev/fsl_rmu.c >>> index 1548578..468011e 100644 >>> --- a/arch/powerpc/sysdev/fsl_rmu.c >>> +++ b/arch/powerpc/sysdev

Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-05 Thread Liu Gang
Hi, Kumar, On Fri, 2012-03-02 at 09:11 -0600, Kumar Gala wrote: > > diff --git a/arch/powerpc/sysdev/fsl_rmu.c b/arch/powerpc/sysdev/fsl_rmu.c > > index 1548578..468011e 100644 > > --- a/arch/powerpc/sysdev/fsl_rmu.c > > +++ b/arch/powerpc/sysdev/fsl_rmu.c > > @@ -311,8 +311,8 @@ fsl_rio_dbell_han

Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-04 Thread Liu Gang
Hi, Paul, On Fri, 2012-03-02 at 09:30 -0500, Paul Gortmaker wrote: > > Signed-off-by: Liu Gang > > Signed-off-by: Shaohui Xie > > Signed-off-by: Paul Gortmaker > > Hi Liu, > > You can't just go adding a "Signed-off-by:" line for me to a patch that > I've never seen before. Perhaps you meant

Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-02 Thread Kumar Gala
On Mar 2, 2012, at 1:08 AM, Liu Gang wrote: > For the file "arch/powerpc/sysdev/fsl_rmu.c", there will be some compile > errors while using the corenet64_smp_defconfig: > > .../fsl_rmu.c:315: error: cast from pointer to integer of different size > .../fsl_rmu.c:320: error: cast to pointer from i

Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-02 Thread Paul Gortmaker
On 12-03-02 02:08 AM, Liu Gang wrote: > For the file "arch/powerpc/sysdev/fsl_rmu.c", there will be some compile > errors while using the corenet64_smp_defconfig: > > .../fsl_rmu.c:315: error: cast from pointer to integer of different size > .../fsl_rmu.c:320: error: cast to pointer from integer o

RE: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-02 Thread David Laight
> For the file "arch/powerpc/sysdev/fsl_rmu.c", there will be > some compile errors while using the corenet64_smp_defconfig: I'm sure that replacing 'u32' with 'unsigned long' is really the best thing to do here. It looks to me as though they should be some pointer type. David __

[PATCH] powerpc/srio: Fix the compile errors when building with 64bit

2012-03-01 Thread Liu Gang
For the file "arch/powerpc/sysdev/fsl_rmu.c", there will be some compile errors while using the corenet64_smp_defconfig: .../fsl_rmu.c:315: error: cast from pointer to integer of different size .../fsl_rmu.c:320: error: cast to pointer from integer of different size .../fsl_rmu.c:320: error: cast