Simon Guo writes:
> Thanks for the feedback regarding too many ifdefs. Is following implemention
> better for this issue?
Yes that looks much better. Can you send a proper patch with a change
log and so on, thanks.
cheers
On Fri, Sep 09, 2016 at 08:52:52PM +1000, Michael Ellerman wrote:
> I do - Sorry Simon but your patch just adds too many #ifdefs.
>
> Any time you have to do something like:
>
> +#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
> }
> +#endif
>
> It should be a sign that something ha
Daniel Axtens writes:
> [ Unknown signature status ]
> Simon Guo writes:
>
>> I think keeping tm_active argument for "ifndef CONFIG_PPC_TRANSACTIONAL_MEM"
>> case (with __maybe_unused prefix) will be somehow strange -- Whatever
>> value is provided in the caller function for tm_active, programm
Simon Guo writes:
> I think keeping tm_active argument for "ifndef CONFIG_PPC_TRANSACTIONAL_MEM"
> case (with __maybe_unused prefix) will be somehow strange -- Whatever
> value is provided in the caller function for tm_active, programmer might be
> puzzled and cost sometime to think about it.
Hi Daniel,
On Wed, Aug 24, 2016 at 12:21:23PM +1000, Daniel Axtens wrote:
> Hi Simon,
>
> > The ckpt_regs usage in gpr32_set_common/gpr32_get_common()
> > will lead to cppcheck error.
> >
> > [arch/powerpc/kernel/ptrace.c:2062]: (error) Uninitialized variable:
> > ckpt_regs
> > [arch/powerpc/kern
Hi Simon,
> The ckpt_regs usage in gpr32_set_common/gpr32_get_common()
> will lead to cppcheck error.
>
> [arch/powerpc/kernel/ptrace.c:2062]: (error) Uninitialized variable: ckpt_regs
> [arch/powerpc/kernel/ptrace.c:2130]: (error) Uninitialized variable: ckpt_regs
>
> A straightforward fix to cle
From: Simon Guo
The ckpt_regs usage in gpr32_set_common/gpr32_get_common()
will lead to cppcheck error.
[arch/powerpc/kernel/ptrace.c:2062]: (error) Uninitialized variable: ckpt_regs
[arch/powerpc/kernel/ptrace.c:2130]: (error) Uninitialized variable: ckpt_regs
A straightforward fix to clean it
