Re: [PATCH] powerpc/ptdump: fix W+X verification

2020-01-28 Thread Michael Ellerman
On Tue, 2020-01-14 at 08:13:09 UTC, Christophe Leroy wrote: > Verification cannot rely on simple bit checking because on some > platforms PAGE_RW is 0, checking that a page is not W means > checking that PAGE_RO is set instead of checking that PAGE_RW > is not set. > > Use pte helpers instead of c

Re: [PATCH] powerpc/ptdump: fix W+X verification call in mark_rodata_ro()

2020-01-28 Thread Michael Ellerman
On Tue, 2020-01-14 at 08:13:08 UTC, Christophe Leroy wrote: > ptdump_check_wx() also have to be called when pages are mapped > by blocks. > > Signed-off-by: Christophe Leroy > Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot") Applied to powerpc next, thanks. https://git.kernel

[PATCH] powerpc/ptdump: fix W+X verification call in mark_rodata_ro()

2020-01-14 Thread Christophe Leroy
ptdump_check_wx() also have to be called when pages are mapped by blocks. Signed-off-by: Christophe Leroy Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot") --- arch/powerpc/mm/pgtable_32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/p

[PATCH] powerpc/ptdump: fix W+X verification

2020-01-14 Thread Christophe Leroy
Verification cannot rely on simple bit checking because on some platforms PAGE_RW is 0, checking that a page is not W means checking that PAGE_RO is set instead of checking that PAGE_RW is not set. Use pte helpers instead of checking bits. Signed-off-by: Christophe Leroy Fixes: 453d87f6a8ae ("po