Re: [PATCH] powerpc/pseries: Fix dtl_access_lock to be a rw_semaphore

2024-11-07 Thread Michael Ellerman
On Mon, 19 Aug 2024 22:24:01 +1000, Michael Ellerman wrote: > The dtl_access_lock needs to be a rw_sempahore, a sleeping lock, because > the code calls kmalloc() while holding it, which can sleep: > > # echo 1 > /proc/powerpc/vcpudispatch_stats > BUG: sleeping function called from invalid cont

Re: [PATCH] powerpc/pseries: Fix dtl_access_lock to be a rw_semaphore

2024-08-26 Thread kajoljain
Hi Michael, Thanks for the patch, the patch looks fine to me. Tested-by: Kajol Jain Reviewed-by: Kajol Jain Thanks, Kajol Jain On 8/19/24 17:54, Michael Ellerman wrote: > The dtl_access_lock needs to be a rw_sempahore, a sleeping lock, because > the code calls kmalloc() while holding it, whic

Re: [PATCH] powerpc/pseries: Fix dtl_access_lock to be a rw_semaphore

2024-08-21 Thread Nysal Jan K.A.
On Mon, Aug 19, 2024 at 10:24:01PM GMT, Michael Ellerman wrote: > Fixes: 06220d78f24a ("powerpc/pseries: Introduce rwlock to gatekeep DTLB > usage") > Signed-off-by: Michael Ellerman > --- > arch/powerpc/include/asm/dtl.h| 3 ++- > arch/powerpc/platforms/pseries/dtl.c | 8 >

[PATCH] powerpc/pseries: Fix dtl_access_lock to be a rw_semaphore

2024-08-19 Thread Michael Ellerman
The dtl_access_lock needs to be a rw_sempahore, a sleeping lock, because the code calls kmalloc() while holding it, which can sleep: # echo 1 > /proc/powerpc/vcpudispatch_stats BUG: sleeping function called from invalid context at include/linux/sched/mm.h:337 in_atomic(): 1, irqs_disabled()