Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-11 Thread Nathan Lynch
Michael Ellerman writes: > Michael Roth writes: >> Quoting Nathan Lynch (2020-08-07 02:05:09) > ... >>> wait_for_cpu_stopped() should be able to accommodate a time-based >>> warning if necessary, but speaking as a likely recipient of any bug >>> reports that would arise here, I'm not convinced o

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-11 Thread Michael Ellerman
Michael Roth writes: > Quoting Nathan Lynch (2020-08-07 02:05:09) ... >> wait_for_cpu_stopped() should be able to accommodate a time-based >> warning if necessary, but speaking as a likely recipient of any bug >> reports that would arise here, I'm not convinced of the need and I >> don't know what

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-10 Thread Michael Roth
Quoting Nathan Lynch (2020-08-07 02:05:09) > Hi everyone, > > Michael Ellerman writes: > > Greg Kurz writes: > >> On Tue, 04 Aug 2020 23:35:10 +1000 > >> Michael Ellerman wrote: > >>> Spinning forever seems like a bad idea, but as has been demonstrated at > >>> least twice now, continuing when

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-07 Thread Nathan Lynch
Hi everyone, Michael Ellerman writes: > Greg Kurz writes: >> On Tue, 04 Aug 2020 23:35:10 +1000 >> Michael Ellerman wrote: >>> Spinning forever seems like a bad idea, but as has been demonstrated at >>> least twice now, continuing when we don't know the state of the other >>> CPU can lead to st

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-06 Thread Michael Ellerman
Michael Roth writes: > Quoting Michael Roth (2020-08-04 23:37:32) >> Quoting Michael Ellerman (2020-08-04 22:07:08) >> > Greg Kurz writes: >> > > On Tue, 04 Aug 2020 23:35:10 +1000 >> > > Michael Ellerman wrote: >> > >> Spinning forever seems like a bad idea, but as has been demonstrated at >> >

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-05 Thread Michael Roth
Quoting Michael Roth (2020-08-05 17:29:28) > Quoting Michael Roth (2020-08-04 23:37:32) > > Quoting Michael Ellerman (2020-08-04 22:07:08) > > > Greg Kurz writes: > > > > On Tue, 04 Aug 2020 23:35:10 +1000 > > > > Michael Ellerman wrote: > > > >> Spinning forever seems like a bad idea, but as has

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-05 Thread Michael Roth
Quoting Michael Roth (2020-08-04 23:37:32) > Quoting Michael Ellerman (2020-08-04 22:07:08) > > Greg Kurz writes: > > > On Tue, 04 Aug 2020 23:35:10 +1000 > > > Michael Ellerman wrote: > > >> Spinning forever seems like a bad idea, but as has been demonstrated at > > >> least twice now, continuin

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-04 Thread Michael Roth
Quoting Michael Ellerman (2020-08-04 22:07:08) > Greg Kurz writes: > > On Tue, 04 Aug 2020 23:35:10 +1000 > > Michael Ellerman wrote: > >> There is a bit of history to this code, but not in a good way :) > >> > >> Michael Roth writes: > >> > For a power9 KVM guest with XIVE enabled, running a t

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-04 Thread Thiago Jung Bauermann
Michael Ellerman writes: > Greg Kurz writes: >> On Tue, 04 Aug 2020 23:35:10 +1000 >> Michael Ellerman wrote: >>> There is a bit of history to this code, but not in a good way :) >>> >>> Michael Roth writes: >>> > For a power9 KVM guest with XIVE enabled, running a test loop >>> > where we h

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-04 Thread Michael Ellerman
Greg Kurz writes: > On Tue, 04 Aug 2020 23:35:10 +1000 > Michael Ellerman wrote: >> There is a bit of history to this code, but not in a good way :) >> >> Michael Roth writes: >> > For a power9 KVM guest with XIVE enabled, running a test loop >> > where we hotplug 384 vcpus and then unplug them

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-04 Thread Greg Kurz
On Tue, 04 Aug 2020 23:35:10 +1000 Michael Ellerman wrote: > Hi Mike, > > There is a bit of history to this code, but not in a good way :) > > Michael Roth writes: > > For a power9 KVM guest with XIVE enabled, running a test loop > > where we hotplug 384 vcpus and then unplug them, the followi

Re: [PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-04 Thread Michael Ellerman
Hi Mike, There is a bit of history to this code, but not in a good way :) Michael Roth writes: > For a power9 KVM guest with XIVE enabled, running a test loop > where we hotplug 384 vcpus and then unplug them, the following traces > can be seen (generally within a few loops) either from the unpl

[PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-03 Thread Michael Roth
For a power9 KVM guest with XIVE enabled, running a test loop where we hotplug 384 vcpus and then unplug them, the following traces can be seen (generally within a few loops) either from the unplugged vcpu: [ 1767.353447] cpu 65 (hwid 65) Ready to die... [ 1767.952096] Querying DEAD? cpu 66 (6