Re: [PATCH] powerpc/powernv: Support OPAL requested heartbeat

2014-11-13 Thread Benjamin Herrenschmidt
On Fri, 2014-11-14 at 14:01 +1100, Alistair Popple wrote: > Hi Ben, > > On Wed, 12 Nov 2014 17:03:14 Benjamin Herrenschmidt wrote: > > > > > + > > +static int kopald(void *unused) > > +{ > > + set_freezable(); > > + do { > > + try_to_freeze(); > > + opal_poll_events(NULL

Re: [PATCH] powerpc/powernv: Support OPAL requested heartbeat

2014-11-13 Thread Alistair Popple
Hi Ben, On Wed, 12 Nov 2014 17:03:14 Benjamin Herrenschmidt wrote: > + > +static int kopald(void *unused) > +{ > + set_freezable(); > + do { > + try_to_freeze(); > + opal_poll_events(NULL); Do we need to check for outstanding events (and call opal_do_notifier)?

Re: [PATCH] powerpc/powernv: Support OPAL requested heartbeat

2014-11-13 Thread Benjamin Herrenschmidt
On Thu, 2014-11-13 at 10:59 -0600, Paul Clarke wrote: > On 11/12/2014 12:03 AM, Benjamin Herrenschmidt wrote: > > If OPAL requests it, call it back via opal_poll_events() at a > > regular interval. Some versions of OPAL on some machines require > > this to operate some internal timeouts properly. >

Re: [PATCH] powerpc/powernv: Support OPAL requested heartbeat

2014-11-13 Thread Paul Clarke
On 11/12/2014 12:03 AM, Benjamin Herrenschmidt wrote: If OPAL requests it, call it back via opal_poll_events() at a regular interval. Some versions of OPAL on some machines require this to operate some internal timeouts properly. I don't see any reason why not, but wanted to ask to make sure: t

[PATCH] powerpc/powernv: Support OPAL requested heartbeat

2014-11-11 Thread Benjamin Herrenschmidt
If OPAL requests it, call it back via opal_poll_events() at a regular interval. Some versions of OPAL on some machines require this to operate some internal timeouts properly. Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/platforms/powernv/opal.c | 64 ++-