Re: [PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations

2014-05-22 Thread Cody P Schafer
On 05/22/2014 03:38 PM, Stephen Rothwell wrote: Hi Cody, On Thu, 22 May 2014 15:29:08 -0700 Cody P Schafer wrote: - *res = be64_to_cpu(result_buffer.result); + *res = be64_to_cpu(result_buffer->result); + kfree(result_buffer); + kfree(request_buffer); + return r

Re: [PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations

2014-05-22 Thread Stephen Rothwell
Hi Cody, On Thu, 22 May 2014 15:29:08 -0700 Cody P Schafer wrote: > > - *res = be64_to_cpu(result_buffer.result); > + *res = be64_to_cpu(result_buffer->result); > + kfree(result_buffer); > + kfree(request_buffer); > + return ret; Why not just fall through here by removing th

[PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations

2014-05-22 Thread Cody P Schafer
Ian pointed out the use of __aligned(4096) caused rather large stack consumption in single_24x7_request(), so use the kmem_cache hv_page_cache (which we've already got set up for other allocations) insead of allocating locally. Reported-by: Ian Munsie Signed-off-by: Cody P Schafer --- arch/powe