Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-21 Thread Grant Likely
On Thu, May 21, 2009 at 11:43 AM, Segher Boessenkool wrote: >> However, on the other point, Jon is correct.  The first value in the >> list should be "atmel,24c32", not "at24,24c32". > > Yeah.  So perhaps "atmel,24c32","24c32" ?  I'm not terribly happy > with that last name, but these devices are

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-21 Thread Segher Boessenkool
As the other thread states, "eeprom" is far too vague, and it is certainly not documented, and does not say anything meaningful about the protocol used to talk to the eeprom. Sure, most i2c eeproms use the same protocol, Not at all! Pretty much every size of 24c has its own protocol; and some

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Grant Likely
On Wed, May 20, 2009 at 10:25 AM, Grant Likely wrote: > On Wed, May 20, 2009 at 10:15 AM, Wolfram Sang wrote: >> On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote: >>> On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang >>> wrote: >>> >> > -                       /* FIXME: EEPROM */ >>> >> >

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Grant Likely
On Wed, May 20, 2009 at 10:15 AM, Wolfram Sang wrote: > On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote: >> On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang wrote: >> >> > -                       /* FIXME: EEPROM */ >> >> > +                       eep...@52 { >> >> > +                    

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Wolfram Sang
On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote: > On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang wrote: > >> > -                       /* FIXME: EEPROM */ > >> > +                       eep...@52 { > >> > +                               compatible = "at24,24c32"; > >> > +              

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Jon Smirl
On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang wrote: >> > -                       /* FIXME: EEPROM */ >> > +                       eep...@52 { >> > +                               compatible = "at24,24c32"; >> > +                               reg = <0x52>; >> > +                       }; >> >> G

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Wolfram Sang
> > -                       /* FIXME: EEPROM */ > > +                       eep...@52 { > > +                               compatible = "at24,24c32"; > > +                               reg = <0x52>; > > +                       }; > > Grant suggested this earlier... > eep...

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Jon Smirl
On Wed, May 20, 2009 at 4:07 AM, Wolfram Sang wrote: > Add a node for the i2c eeprom and delete the superflous gpio-example. > > Signed-off-by: Wolfram Sang > Cc: Grant Likely > Cc: linuxppc-dev@ozlabs.org > --- >  arch/powerpc/boot/dts/pcm030.dts |   26 -- >  1 files cha

[PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Wolfram Sang
Add a node for the i2c eeprom and delete the superflous gpio-example. Signed-off-by: Wolfram Sang Cc: Grant Likely Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/boot/dts/pcm030.dts | 26 -- 1 files changed, 4 insertions(+), 22 deletions(-) diff --git a/arch/powerpc/boo