Re: [PATCH] powerpc/pci: Avoid overriding MSI interrupt

2013-06-29 Thread Benjamin Herrenschmidt
On Sun, 2013-06-30 at 09:51 +0800, Gavin Shan wrote: > Ben, I think one patch was lost from mainline and that fixes the problem. > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=5fb621698e94e3af8b413d9439041fde48e2784d > > I had the patch applied to /home/benh/linu

Re: [PATCH] powerpc/pci: Avoid overriding MSI interrupt

2013-06-29 Thread Gavin Shan
On Sun, Jun 30, 2013 at 09:09:20AM +1000, Benjamin Herrenschmidt wrote: >On Fri, 2013-06-28 at 21:10 +0800, Gavin Shan wrote: .../... >I'm running some tests, so far it looks good. However, Gavin, when you >have a chance on vpl3, try injecting errors to other adapters, for >example the VGA adapte

Re: [PATCH] powerpc/pci: Avoid overriding MSI interrupt

2013-06-29 Thread Guenter Roeck
On Sun, Jun 30, 2013 at 09:09:20AM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2013-06-28 at 21:10 +0800, Gavin Shan wrote: > > The issue was introduced by commit 37f02195 ("powerpc/pci: fix > > PCI-e devices rescan issue on powerpc platform"). The field > > (struct pci_dev::irq) is reused by PC

Re: [PATCH] powerpc/pci: Avoid overriding MSI interrupt

2013-06-29 Thread Benjamin Herrenschmidt
On Fri, 2013-06-28 at 21:10 +0800, Gavin Shan wrote: > The issue was introduced by commit 37f02195 ("powerpc/pci: fix > PCI-e devices rescan issue on powerpc platform"). The field > (struct pci_dev::irq) is reused by PCI core to trace the base > MSI interrupt number if the MSI stuff is enabled on t

Re: [PATCH] powerpc/pci: Avoid overriding MSI interrupt

2013-06-29 Thread Benjamin Herrenschmidt
On Fri, 2013-06-28 at 21:10 +0800, Gavin Shan wrote: > The issue was introduced by commit 37f02195 ("powerpc/pci: fix > PCI-e devices rescan issue on powerpc platform"). The field That "fix" caused more problems than it solved. There's a better approach floating around that I will merge eventually

[PATCH] powerpc/pci: Avoid overriding MSI interrupt

2013-06-28 Thread Gavin Shan
The issue was introduced by commit 37f02195 ("powerpc/pci: fix PCI-e devices rescan issue on powerpc platform"). The field (struct pci_dev::irq) is reused by PCI core to trace the base MSI interrupt number if the MSI stuff is enabled on the corresponding device. When running to pcibios_setup_device