Re: [PATCH] powerpc/modules: Use WARN_ON() in stub_for_addr()

2017-10-11 Thread Michael Ellerman
Kamalesh Babulal writes: > On Wednesday 11 October 2017 09:42 AM, Michael Ellerman wrote: >> Kamalesh Babulal writes: >> >>> Use WARN_ON(), while running out of stubs in stub_for_addr() >>> and abort loading of the module instead of BUG_ON(). >> >> Thanks. This looks good in principle. Have yo

Re: [PATCH] powerpc/modules: Use WARN_ON() in stub_for_addr()

2017-10-10 Thread Kamalesh Babulal
On Wednesday 11 October 2017 09:42 AM, Michael Ellerman wrote: > Kamalesh Babulal writes: > >> Use WARN_ON(), while running out of stubs in stub_for_addr() >> and abort loading of the module instead of BUG_ON(). > > Thanks. This looks good in principle. Have you actually tested it to > make sure

Re: [PATCH] powerpc/modules: Use WARN_ON() in stub_for_addr()

2017-10-10 Thread Michael Ellerman
Kamalesh Babulal writes: > Use WARN_ON(), while running out of stubs in stub_for_addr() > and abort loading of the module instead of BUG_ON(). Thanks. This looks good in principle. Have you actually tested it to make sure we do in fact gracefully fail the module load? cheers

[PATCH] powerpc/modules: Use WARN_ON() in stub_for_addr()

2017-10-10 Thread Kamalesh Babulal
Use WARN_ON(), while running out of stubs in stub_for_addr() and abort loading of the module instead of BUG_ON(). Signed-off-by: Kamalesh Babulal --- arch/powerpc/kernel/module_64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/module_64.c b/arch/power