Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

2019-05-21 Thread Joe Perches
On Tue, 2019-05-21 at 16:27 +0900, Masahiro Yamada wrote: > On Tue, May 21, 2019 at 3:54 PM Christophe Leroy > > powerpc accepts lines up to 90 chars, see arch/powerpc/tools/checkpatch.pl > > Ugh, I did not know this. Horrible. > > The Linux coding style should be global in the kernel tree. > No

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

2019-05-21 Thread Michael Ellerman
Masahiro Yamada writes: > On Tue, May 21, 2019 at 3:54 PM Christophe Leroy > wrote: >> Le 21/05/2019 à 08:16, Masahiro Yamada a écrit : >> > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error >> > with gcc 9.1.1: >> > >> >arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlb

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

2019-05-21 Thread Masahiro Yamada
On Tue, May 21, 2019 at 3:54 PM Christophe Leroy wrote: > > > > Le 21/05/2019 à 08:16, Masahiro Yamada a écrit : > > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error > > with gcc 9.1.1: > > > >arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': > >arch/powerp

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

2019-05-21 Thread Joe Perches
On Tue, 2019-05-21 at 08:53 +0200, Christophe Leroy wrote: > powerpc accepts lines up to 90 chars, see arch/powerpc/tools/checkpatch.pl arch/powerpc/tools/checkpatch.sh

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

2019-05-20 Thread Christophe Leroy
Le 21/05/2019 à 08:16, Masahiro Yamada a écrit : With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error with gcc 9.1.1: arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably doesn't match

[PATCH] powerpc/mm: mark more tlb functions as __always_inline

2019-05-20 Thread Masahiro Yamada
With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error with gcc 9.1.1: arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably doesn't match constraints 104 | asm volatile(PPC_TLBIEL(%0, %4,