Re: [PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()

2022-10-12 Thread Naveen N. Rao
Li Huafei wrote:   # echo 'p cmdline_proc_show' > kprobe_events   # echo 'p cmdline_proc_show+16' >> kprobe_events I think we should extend multiple_kprobes selftest to also place contiguous probes to catch such errors. Yes. But each architecture implementation is different and it looks a li

Re: [PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()

2022-10-11 Thread Li Huafei
On 2022/9/30 17:47, Naveen N. Rao wrote: > Li Huafei wrote: >> I found a null pointer reference in arch_prepare_kprobe(): > > Good find! > Hi Naveen, Thank you for the review. >> >>   # echo 'p cmdline_proc_show' > kprobe_events >>   # echo 'p cmdline_proc_show+16' >> kprobe_events > > I th

Re: [PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()

2022-10-04 Thread Michael Ellerman
On Fri, 23 Sep 2022 17:32:53 +0800, Li Huafei wrote: > I found a null pointer reference in arch_prepare_kprobe(): > > # echo 'p cmdline_proc_show' > kprobe_events > # echo 'p cmdline_proc_show+16' >> kprobe_events > [ 67.278533][ T122] Kernel attempted to read user page (0) - exploit > a

Re: [PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()

2022-09-30 Thread Naveen N. Rao
Li Huafei wrote: I found a null pointer reference in arch_prepare_kprobe(): Good find! # echo 'p cmdline_proc_show' > kprobe_events # echo 'p cmdline_proc_show+16' >> kprobe_events I think we should extend multiple_kprobes selftest to also place contiguous probes to catch such errors.

[PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()

2022-09-23 Thread Li Huafei
I found a null pointer reference in arch_prepare_kprobe(): # echo 'p cmdline_proc_show' > kprobe_events # echo 'p cmdline_proc_show+16' >> kprobe_events [ 67.278533][ T122] Kernel attempted to read user page (0) - exploit attempt? (uid: 0) [ 67.279326][ T122] BUG: Kernel NULL pointe