Re: [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-21 Thread Christophe Leroy
Le 21/03/2019 à 11:07, Michael Ellerman a écrit : Christophe Leroy writes: Le 21/03/2019 à 06:29, Michael Ellerman a écrit : Christophe Leroy writes: In arch/powerpc/mm/highmem.c, BUG_ON() is called only when CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is not vital and can

Re: [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-21 Thread Michael Ellerman
Christophe Leroy writes: > Le 21/03/2019 à 06:29, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> In arch/powerpc/mm/highmem.c, BUG_ON() is called only when >>> CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is >>> not vital and can be replaced by a a WARN_ON >>> >>> At the

Re: [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-20 Thread Christophe Leroy
Le 21/03/2019 à 06:29, Michael Ellerman a écrit : Christophe Leroy writes: In arch/powerpc/mm/highmem.c, BUG_ON() is called only when CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is not vital and can be replaced by a a WARN_ON At the sametime, use IS_ENABLED() instead of #ifdef

Re: [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-20 Thread Michael Ellerman
Christophe Leroy writes: > In arch/powerpc/mm/highmem.c, BUG_ON() is called only when > CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is > not vital and can be replaced by a a WARN_ON > > At the sametime, use IS_ENABLED() instead of #ifdef to clean a bit. > > Signed-off-by: Christophe

[PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-07 Thread Christophe Leroy
In arch/powerpc/mm/highmem.c, BUG_ON() is called only when CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is not vital and can be replaced by a a WARN_ON At the sametime, use IS_ENABLED() instead of #ifdef to clean a bit. Signed-off-by: Christophe Leroy --- arch/powerpc/mm/highmem.c