Re: [PATCH] powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2015-10-26 Thread Daniel Axtens
Andrew Donnellan writes: > diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c > index 40e4d4a..d757e7c 100644 > --- a/arch/powerpc/kernel/eeh.c > +++ b/arch/powerpc/kernel/eeh.c > @@ -677,7 +677,7 @@ int eeh_pci_enable(struct eeh_pe *pe, int function) > /* Check if the requ

Re: [PATCH] powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2015-10-26 Thread Daniel Axtens
Andrew Donnellan writes: > diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c > index 40e4d4a..d757e7c 100644 > --- a/arch/powerpc/kernel/eeh.c > +++ b/arch/powerpc/kernel/eeh.c > @@ -677,7 +677,7 @@ int eeh_pci_enable(struct eeh_pe *pe, int function) > /* Check if the requ

Re: [PATCH] powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2015-10-23 Thread Gavin Shan
On Fri, Oct 23, 2015 at 05:19:46PM +1100, Andrew Donnellan wrote: >In eeh_pci_enable(), after making the request to set the new options, we >call eeh_ops->wait_state() to check that the request finished successfully. > >At the moment, if eeh_ops->wait_state() returns 0, we return 0 without >checkin

[PATCH] powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2015-10-22 Thread Andrew Donnellan
In eeh_pci_enable(), after making the request to set the new options, we call eeh_ops->wait_state() to check that the request finished successfully. At the moment, if eeh_ops->wait_state() returns 0, we return 0 without checking that it reflects the expected outcome. This can lead to callers furth