Re: [PATCH] powerpc/eeh: Refactor EEH PE reset functions

2016-11-18 Thread Michael Ellerman
Russell Currey writes: > eeh_pe_reset and eeh_reset_pe are two different functions in the same > file which do mostly the same thing. Not only is this confusing, but > potentially causes disrepancies in functionality, notably eeh_reset_pe > as it does not check return values for failure. > > Ref

Re: [PATCH] powerpc/eeh: Refactor EEH PE reset functions

2016-11-17 Thread Russell Currey
On Fri, 2016-11-18 at 10:59 +1100, Gavin Shan wrote: > On Thu, Nov 17, 2016 at 04:07:47PM +1100, Russell Currey wrote: > > eeh_pe_reset and eeh_reset_pe are two different functions in the same > > file which do mostly the same thing.  Not only is this confusing, but > > potentially causes disrepanc

Re: [PATCH] powerpc/eeh: Refactor EEH PE reset functions

2016-11-17 Thread Gavin Shan
On Thu, Nov 17, 2016 at 04:07:47PM +1100, Russell Currey wrote: >eeh_pe_reset and eeh_reset_pe are two different functions in the same >file which do mostly the same thing. Not only is this confusing, but >potentially causes disrepancies in functionality, notably eeh_reset_pe >as it does not check

[PATCH] powerpc/eeh: Refactor EEH PE reset functions

2016-11-16 Thread Russell Currey
eeh_pe_reset and eeh_reset_pe are two different functions in the same file which do mostly the same thing. Not only is this confusing, but potentially causes disrepancies in functionality, notably eeh_reset_pe as it does not check return values for failure. Refactor this into the following: - e