Re: [PATCH] powerpc/crypto/crct10dif-vpmsum: Fix missing preempt_disable()

2017-04-19 Thread Michael Ellerman
Daniel Axtens writes: > Hi Michael, > >> Fixes: b01df1c16c9a ("crypto: powerpc - Add CRC-T10DIF acceleration") > > Thank you very much for doing this! (and my apologies for not doing it > myself!) No worries, the enable_altivec() API is ridiculous, I'm surprised we ever get it right. > It all l

Re: [PATCH] powerpc/crypto/crct10dif-vpmsum: Fix missing preempt_disable()

2017-04-19 Thread Daniel Axtens
Hi Michael, > Fixes: b01df1c16c9a ("crypto: powerpc - Add CRC-T10DIF acceleration") Thank you very much for doing this! (and my apologies for not doing it myself!) It all looks good to me. I think an Ack is appropriate in these circumstances? Acked-by: Daniel Axtens Regards, Daniel

[PATCH] powerpc/crypto/crct10dif-vpmsum: Fix missing preempt_disable()

2017-04-18 Thread Michael Ellerman
In crct10dif_vpmsum() we call enable_kernel_altivec() without first disabling preemption, which is not allowed. It used to be sufficient just to call pagefault_disable(), because that also disabled preemption. But the two were decoupled in commit 8222dbe21e79 ("sched/preempt, mm/fault: Decouple pr