Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-04-19 Thread Kumar Gala
On Nov 30, 2011, at 10:19 AM, Timur Tabi wrote: > Commit 46d026ac ("powerpc/85xx: consolidate of_platform_bus_probe calls") > replaced platform-specific of_device_id tables with a single function > that probes the most of the busses in 85xx device trees. If a specific > platform needed additiona

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-27 Thread Grant Likely
On Tue, 27 Mar 2012 13:18:10 -0500, Timur Tabi wrote: > Grant, do you have a moment to consider my question? Like I said, I'm > anxious to get a fix into 3.3. I've been out of town for the past week, so email processing volume has been low. Answer below. > Timur Tabi wrote: > > Timur Tabi wrot

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-27 Thread Timur Tabi
Grant, do you have a moment to consider my question? Like I said, I'm anxious to get a fix into 3.3. Timur Tabi wrote: > Timur Tabi wrote: >> They only problem I see with this is that I am thinking about modifying >> the drivers/dma driver to probe on "fsl,eloplus-dma-channel" channels >> directl

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-21 Thread Timur Tabi
Timur Tabi wrote: > They only problem I see with this is that I am thinking about modifying > the drivers/dma driver to probe on "fsl,eloplus-dma-channel" channels > directly. If I do that, then who should call of_platform_populate()? Grant, could you tell me if there's anything actually work wit

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-21 Thread Kumar Gala
On Mar 19, 2012, at 11:04 AM, Grant Likely wrote: > On Fri, 16 Mar 2012 15:50:44 -0500, Timur Tabi wrote: >> Kumar Gala wrote: >> >>> This seems like paper taping over the real issue. We should be able to >>> call of_platform_bus_probe() multiple times. >> >> I tried debugging it, but I coul

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-20 Thread Timur Tabi
Grant Likely wrote: > Does a driver bind against "fsl,eloplus-dma"? If so, then I would > call of_platform_populate() from within the fsl,eloplus-dma driver's > probe method. Well, there are two "DMA" drivers. The one in drivers/dma binds on fsl,eloplus-dma, and then manually scans for children

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-20 Thread Grant Likely
On Mon, 19 Mar 2012 13:43:29 -0500, Timur Tabi wrote: > Grant Likely wrote: > > The problem is that you want to create devices for grandchildren > > nodes when the bus ids passed in don't match any of the child nodes so > > the of_platform_bus_probe() doesn't iterate down to that level. This > >

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-19 Thread Timur Tabi
Grant Likely wrote: > The problem is that you want to create devices for grandchildren > nodes when the bus ids passed in don't match any of the child nodes so > the of_platform_bus_probe() doesn't iterate down to that level. This > is correct and expected behaviour. Well, I'm not still not 100%

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-19 Thread Grant Likely
On Fri, 16 Mar 2012 15:50:44 -0500, Timur Tabi wrote: > Kumar Gala wrote: > > > This seems like paper taping over the real issue. We should be able to > > call of_platform_bus_probe() multiple times. > > I tried debugging it, but I couldn't figure it out. My guess is that the > nodes probed b

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-16 Thread Timur Tabi
Kumar Gala wrote: > This seems like paper taping over the real issue. We should be able to call > of_platform_bus_probe() multiple times. I tried debugging it, but I couldn't figure it out. My guess is that the nodes probed by of_platform_bus_probe() are somehow "reserved", so that the second

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-16 Thread Kumar Gala
On Nov 30, 2011, at 10:19 AM, Timur Tabi wrote: > Commit 46d026ac ("powerpc/85xx: consolidate of_platform_bus_probe calls") > replaced platform-specific of_device_id tables with a single function > that probes the most of the busses in 85xx device trees. If a specific > platform needed additiona

Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2012-03-07 Thread Timur Tabi
Timur Tabi wrote: > Commit 46d026ac ("powerpc/85xx: consolidate of_platform_bus_probe calls") > replaced platform-specific of_device_id tables with a single function > that probes the most of the busses in 85xx device trees. If a specific > platform needed additional busses probed, then it could c

[PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice

2011-11-30 Thread Timur Tabi
Commit 46d026ac ("powerpc/85xx: consolidate of_platform_bus_probe calls") replaced platform-specific of_device_id tables with a single function that probes the most of the busses in 85xx device trees. If a specific platform needed additional busses probed, then it could call of_platform_bus_probe(