Re: [PATCH] powerpc/44x: mask and shift to zero bug

2017-08-28 Thread Michael Ellerman
Dan Carpenter writes: > On Sun, Aug 27, 2017 at 02:56:31PM +1000, Benjamin Herrenschmidt wrote: >> On Fri, 2017-08-25 at 13:33 +0300, Dan Carpenter wrote: >> > My static checker complains that 0x1800 >> 13 is zero. Looking at >> > the context, it seems like a copy and paste bug from the line

Re: [PATCH] powerpc/44x: mask and shift to zero bug

2017-08-28 Thread Dan Carpenter
On Mon, Aug 28, 2017 at 10:57:05AM +0300, Dan Carpenter wrote: > I sent this email during kernel summit and neither of us could send a > patch at the time and we both problem forgot. I definitely forgot. > s/problem/probably/... I suck at email. :( regards, dan carpenter

Re: [PATCH] powerpc/44x: mask and shift to zero bug

2017-08-28 Thread Dan Carpenter
On Sun, Aug 27, 2017 at 02:56:31PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2017-08-25 at 13:33 +0300, Dan Carpenter wrote: > > My static checker complains that 0x1800 >> 13 is zero. Looking at > > the context, it seems like a copy and paste bug from the line below and > > probably 0x3 <

Re: [PATCH] powerpc/44x: mask and shift to zero bug

2017-08-26 Thread Benjamin Herrenschmidt
On Fri, 2017-08-25 at 13:33 +0300, Dan Carpenter wrote: > My static checker complains that 0x1800 >> 13 is zero. Looking at > the context, it seems like a copy and paste bug from the line below and > probably 0x3 << 13 or 0x6000 was intended. > > Fixes: 2af59f7d5c3e ("[POWERPC] 4xx: Add 4

[PATCH] powerpc/44x: mask and shift to zero bug

2017-08-25 Thread Dan Carpenter
My static checker complains that 0x1800 >> 13 is zero. Looking at the context, it seems like a copy and paste bug from the line below and probably 0x3 << 13 or 0x6000 was intended. Fixes: 2af59f7d5c3e ("[POWERPC] 4xx: Add 405GPr and 405EP support in boot wrapper") Signed-off-by: Dan Carp