Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-28 Thread Tanmay Inamdar
On Mon, Nov 28, 2011 at 4:49 AM, Benjamin Herrenschmidt wrote: > On Fri, 2011-11-25 at 17:49 +0530, Tanmay Inamdar wrote: > >> >>         > >>         > +#if defined(CONFIG_APM8018X) >>         > +/* CPR */ >>         > +#define DCRN_CPR0_CONFIG_ADDR        0xa >>         > +#define DCRN_CPR1_CONF

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-27 Thread Benjamin Herrenschmidt
On Fri, 2011-11-25 at 17:49 +0530, Tanmay Inamdar wrote: > > > > > +#if defined(CONFIG_APM8018X) > > +/* CPR */ > > +#define DCRN_CPR0_CONFIG_ADDR0xa > > +#define DCRN_CPR1_CONFIG_DATA0xb > > +/* AHB */ > > +#define D

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-25 Thread Tanmay Inamdar
Hello Arnd, Thanks for the comments. Please see inline replies. Regards, Tanmay On Wed, Nov 23, 2011 at 7:45 PM, Arnd Bergmann wrote: > On Wednesday 23 November 2011, Tanmay Inamdar wrote: > > The AppliedMicro APM8018X embedded processor targets embedded > applications that > > require low pow

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-25 Thread Arnd Bergmann
On Friday 25 November 2011, Tanmay Inamdar wrote: > > > > > > +#if defined(CONFIG_APM8018X) > > > +/* CPR */ > > > +#define DCRN_CPR0_CONFIG_ADDR0xa > > > +#define DCRN_CPR1_CONFIG_DATA0xb > > > +/* AHB */ > > > +#define DCRN_SDR1_CONFIG_ADDR0xc > > > +#define DCRN_SDR1_CONF

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-25 Thread Tanmay Inamdar
Hello, Please see inline comment. Regards, Tanmay On Wed, Nov 23, 2011 at 9:46 PM, Kumar Gala wrote: > > On Nov 23, 2011, at 3:44 AM, Tanmay Inamdar wrote: > > > arch/powerpc/kernel/udbg_16550.c            |   22 + > > Would be probably good to split this change into its own patch. Sure. I wil

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-24 Thread Tanmay Inamdar
Hello Josh, Thanks for the review. The comments are appreciated. Please see my inline replies. Thanks, Tanmay On Wed, Nov 23, 2011 at 7:40 PM, Josh Boyer wrote: > On Wed, Nov 23, 2011 at 4:44 AM, Tanmay Inamdar wrote: > > > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > > index

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-23 Thread Tanmay
Hello, Thanks for the comments. Please see inline. Regards, Tanmay On Wed, Nov 23, 2011 at 3:53 PM, Paul Bolle wrote: > Tanmay, > > (Some minor Kconfig related comments follow.) > > On Wed, 2011-11-23 at 15:14 +0530, Tanmay Inamdar wrote: > > The AppliedMicro APM8018X embedded processor target

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-23 Thread Kumar Gala
On Nov 23, 2011, at 3:44 AM, Tanmay Inamdar wrote: > arch/powerpc/kernel/udbg_16550.c| 22 + Would be probably good to split this change into its own patch. - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozl

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-23 Thread Arnd Bergmann
On Wednesday 23 November 2011, Tanmay Inamdar wrote: > The AppliedMicro APM8018X embedded processor targets embedded applications > that > require low power and a small footprint. It features a PowerPC 405 processor > core built in a 65nm low-power CMOS process with a five-stage pipeline > execut

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-23 Thread Josh Boyer
On Wed, Nov 23, 2011 at 4:44 AM, Tanmay Inamdar wrote: > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index b177caa..3f2cc36 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -978,3 +978,9 @@ config PPC_LIB_RHEAP >        bool > >  source "arch/powerpc/kvm/Kconf

Re: [PATCH] powerpc/40x: Add APM8018X SOC support

2011-11-23 Thread Paul Bolle
Tanmay, (Some minor Kconfig related comments follow.) On Wed, 2011-11-23 at 15:14 +0530, Tanmay Inamdar wrote: > The AppliedMicro APM8018X embedded processor targets embedded applications > that > require low power and a small footprint. It features a PowerPC 405 processor > core built in a 65nm