Re: [PATCH] pata_platform struct resource signness fix

2008-09-28 Thread Jeff Garzik
Anton Vorontsov wrote: On Thu, Sep 25, 2008 at 06:40:59PM +0800, Li Yang wrote: On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <[EMAIL PROTECTED]> wrote: The alternative fix can be. This one is better as 0 is defined as 'invalid irq' for all architectures. Added linux-ide and Anton to cc. Thank

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Anton Vorontsov
On Thu, Sep 25, 2008 at 11:33:35PM +0800, Wang Jian wrote: > Li Yang wrote: >> On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <[EMAIL PROTECTED]> wrote: >>> The alternative fix can be. >> >> This one is better as 0 is defined as 'invalid irq' for all >> architectures. Added linux-ide and Anton to cc.

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
Li Yang wrote: On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <[EMAIL PROTECTED]> wrote: The alternative fix can be. This one is better as 0 is defined as 'invalid irq' for all architectures. Added linux-ide and Anton to cc. However, this is not very true. Just git grep "#define NO_IRQ" and see

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Anton Vorontsov
On Thu, Sep 25, 2008 at 06:40:59PM +0800, Li Yang wrote: > On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <[EMAIL PROTECTED]> wrote: > > The alternative fix can be. > > This one is better as 0 is defined as 'invalid irq' for all > architectures. Added linux-ide and Anton to cc. Thanks for the correc

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Li Yang
On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <[EMAIL PROTECTED]> wrote: > The alternative fix can be. This one is better as 0 is defined as 'invalid irq' for all architectures. Added linux-ide and Anton to cc. - Leo > > diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
As I said, I didn't spend much time on the issue, so I don't know which patch is better. (But I do think the patch to pata_of_platform.c is better ATM). AFAIK, powerpc is the only consumer of pata_of_platform.c, so I think this list is better for discussion. I should cc: Anton Vorontsov <[EMAIL

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Leo Li
On Thu, Sep 25, 2008 at 4:36 PM, Wang Jian <[EMAIL PROTECTED]> wrote: > Hi, > > This patch is to pata_platform.c but at this time, it's powerpc specific > because it can only be triggerred using openfirmware, so I post the patch > here. The patch is against 2.6.26-rc8. Powerpc isn't the only arch

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
The alternative fix can be. diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c index 408da30..1f18ad9 100644 --- a/drivers/ata/pata_of_platform.c +++ b/drivers/ata/pata_of_platform.c @@ -52,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct of_device *ofdev,

[PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
Hi, This patch is to pata_platform.c but at this time, it's powerpc specific because it can only be triggerred using openfirmware, so I post the patch here. The patch is against 2.6.26-rc8. The problem is triggerred when ata device is populated using pata_of_platform.c, and no irq is assigned (p