Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-23 Thread Scott Wood
On 07/22/2012 08:56 PM, Rob Herring wrote: > On 07/18/2012 11:04 AM, Scott Wood wrote: >> On 07/17/2012 09:38 PM, Rob Herring wrote: >>> On 07/17/2012 08:11 PM, Scott Wood wrote: Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible property first") breaks the gianfar

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-22 Thread Rob Herring
On 07/18/2012 11:04 AM, Scott Wood wrote: > On 07/17/2012 09:38 PM, Rob Herring wrote: >> On 07/17/2012 08:11 PM, Scott Wood wrote: >>> Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible >>> property first") breaks the gianfar ethernet driver found on various >>> Freescale PP

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-18 Thread Scott Wood
On 07/17/2012 09:38 PM, Rob Herring wrote: > On 07/17/2012 08:11 PM, Scott Wood wrote: >> Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible >> property first") breaks the gianfar ethernet driver found on various >> Freescale PPC chips. > > You do know this is reverted, righ

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-17 Thread Rob Herring
On 07/17/2012 08:11 PM, Scott Wood wrote: > Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible > property first") breaks the gianfar ethernet driver found on various > Freescale PPC chips. You do know this is reverted, right? > > There are, for unfortunate historical reaso

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-17 Thread Tabi Timur-B04825
On Tue, Jul 17, 2012 at 8:11 PM, Scott Wood wrote: > Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible > property first") breaks the gianfar ethernet driver found on various > Freescale PPC chips. > > There are, for unfortunate historical reasons, two nodes with a > compati

[PATCH] of: require a match on all fields of of_device_id

2012-07-17 Thread Scott Wood
Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible property first") breaks the gianfar ethernet driver found on various Freescale PPC chips. There are, for unfortunate historical reasons, two nodes with a compatible of "gianfar". One has a device_type of "network" and the o