Re: [PATCH] of: Fix locking vs. interrupts

2013-06-12 Thread David Miller
From: Grant Likely Date: Wed, 12 Jun 2013 10:06:12 +0100 > On Wed, 12 Jun 2013 10:25:56 +0200 (CEST), Thomas Gleixner > wrote: >> On Wed, 12 Jun 2013, Benjamin Herrenschmidt wrote: >> >> > The OF code uses irqsafe locks everywhere except in a handful of functions >> > for no obvious reasons. S

Re: [PATCH] of: Fix locking vs. interrupts

2013-06-12 Thread Grant Likely
On Wed, 12 Jun 2013 10:25:56 +0200 (CEST), Thomas Gleixner wrote: > On Wed, 12 Jun 2013, Benjamin Herrenschmidt wrote: > > > The OF code uses irqsafe locks everywhere except in a handful of functions > > for no obvious reasons. Since the conversion from the old rwlocks, this > > now triggers loc

Re: [PATCH] of: Fix locking vs. interrupts

2013-06-12 Thread Benjamin Herrenschmidt
On Wed, 2013-06-12 at 10:25 +0200, Thomas Gleixner wrote: > On Wed, 12 Jun 2013, Benjamin Herrenschmidt wrote: > > > The OF code uses irqsafe locks everywhere except in a handful of functions > > for no obvious reasons. Since the conversion from the old rwlocks, this > > now triggers lockdep warni

Re: [PATCH] of: Fix locking vs. interrupts

2013-06-12 Thread Thomas Gleixner
On Wed, 12 Jun 2013, Benjamin Herrenschmidt wrote: > The OF code uses irqsafe locks everywhere except in a handful of functions > for no obvious reasons. Since the conversion from the old rwlocks, this > now triggers lockdep warnings when used at interrupt time. At least one > driver (ibmvscsi) se

[PATCH] of: Fix locking vs. interrupts

2013-06-11 Thread Benjamin Herrenschmidt
The OF code uses irqsafe locks everywhere except in a handful of functions for no obvious reasons. Since the conversion from the old rwlocks, this now triggers lockdep warnings when used at interrupt time. At least one driver (ibmvscsi) seems to be doing that from softirq context. This converts th