Re: [PATCH] of: Feed entire flattened device tree into the random pool

2013-08-29 Thread Grant Likely
On Mon, 29 Jul 2013 13:11:50 +1000, Anton Blanchard wrote: > > Hi, > > > be32_to_cpu(initial_boot_params->totalsize); > > Ouch, thanks Grant. > > Anton > -- > > We feed the entire DMI table into the random pool to provide > better random data during early boot, so do the same with the > flatt

Re: [PATCH] of: Feed entire flattened device tree into the random pool

2013-07-28 Thread Anton Blanchard
Hi, > be32_to_cpu(initial_boot_params->totalsize); Ouch, thanks Grant. Anton -- We feed the entire DMI table into the random pool to provide better random data during early boot, so do the same with the flattened device tree. Signed-off-by: Anton Blanchard --- v3: Fix endian issues as noted

Re: [PATCH] of: Feed entire flattened device tree into the random pool

2013-07-27 Thread Grant Likely
On Thu, 25 Jul 2013 14:30:31 +1000, Anton Blanchard wrote: > > Hi Michael, > > > But why not put the initcall in drivers/of/fdt.c, that way it's not > > early but it's still common ? > > Good idea! How does this look? So long as it happens before > module_init(rand_initialize) we should be good

Re: [PATCH] of: Feed entire flattened device tree into the random pool

2013-07-24 Thread David Gibson
On Thu, Jul 25, 2013 at 02:30:31PM +1000, Anton Blanchard wrote: > > Hi Michael, > > > But why not put the initcall in drivers/of/fdt.c, that way it's not > > early but it's still common ? > > Good idea! How does this look? So long as it happens before > module_init(rand_initialize) we should be

[PATCH] of: Feed entire flattened device tree into the random pool

2013-07-24 Thread Anton Blanchard
Hi Michael, > But why not put the initcall in drivers/of/fdt.c, that way it's not > early but it's still common ? Good idea! How does this look? So long as it happens before module_init(rand_initialize) we should be good. Anton -- We feed the entire DMI table into the random pool to provide be