Re: [PATCH] net: fsl_pq_mdio: fix oops when using uninitialized mutex

2011-11-24 Thread Fleming Andy-AFLEMING
Yes, I sent a patch. Then he sent another patch which breaks things differently. I have not yet submitted my fix. My fix is to revert his patch, and then modify your updated device trees to automatically set the tbi to something. On Nov 24, 2011, at 1:51, "Kumar Gala" wrote: > > On Nov 9, 20

Re: [PATCH] net: fsl_pq_mdio: fix oops when using uninitialized mutex

2011-11-23 Thread Kumar Gala
On Nov 9, 2011, at 2:10 PM, Andy Fleming wrote: >> Fix this by moving the of_mdiobus_register() call earlier. >> >> Cc: Andy Fleming >> Signed-off-by: Baruch Siach >> --- >> drivers/net/ethernet/freescale/fsl_pq_mdio.c | 14 +++--- >> 1 files changed, 7 insertions(+), 7 deletions(-)

Re: [PATCH] net: fsl_pq_mdio: fix oops when using uninitialized mutex

2011-11-09 Thread Andy Fleming
> Fix this by moving the of_mdiobus_register() call earlier. > > Cc: Andy Fleming > Signed-off-by: Baruch Siach > --- >  drivers/net/ethernet/freescale/fsl_pq_mdio.c |   14 +++--- >  1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fsl_pq_md

[PATCH] net: fsl_pq_mdio: fix oops when using uninitialized mutex

2011-11-07 Thread Baruch Siach
The get_phy_id() routine (called via fsl_pq_mdio_find_free()) tries to acquire the mdio_lock mutex which is only initialized when of_mdiobus_register() gets called later. This causes the following oops: Unable to handle kernel paging request for data at address 0x Faulting instruction addr