Re: [PATCH] net: fix OF fixed-link property handling on Freescale network device drivers

2009-07-07 Thread David Miller
From: Anton Vorontsov Date: Tue, 7 Jul 2009 19:12:41 +0400 > ->restart() will dereference phydev, which is NULL. > > grep for 'phydev' in fs_enet/mac-*.c. Ok, so this patch still needs a little bit more work. Thanks for testing! ___ Linuxppc-dev mail

Re: [PATCH] net: fix OF fixed-link property handling on Freescale network device drivers

2009-07-07 Thread Anton Vorontsov
On Fri, Jul 03, 2009 at 04:20:19PM -0600, Grant Likely wrote: > From: Grant Likely > > The MDIO rework patches broke the handling of fixed MII links. [...] > Signed-off-by: Grant Likely > --- > Anton, can you please review, comment and test? I've tested it on an > mpc8349 board, but that is the

Re: [PATCH] net: fix OF fixed-link property handling on Freescale network device drivers

2009-07-07 Thread Anton Vorontsov
On Fri, Jul 03, 2009 at 04:20:19PM -0600, Grant Likely wrote: > From: Grant Likely > > The MDIO rework patches broke the handling of fixed MII links. [...] > Signed-off-by: Grant Likely > --- > Anton, can you please review, comment and test? I've tested it on an > mpc8349 board, but that is the

Re: [PATCH] net: fix OF fixed-link property handling on Freescale network device drivers

2009-07-06 Thread David Miller
From: Grant Likely Date: Fri, 03 Jul 2009 16:20:19 -0600 > Anton, can you please review, comment and test? I've tested it on an > mpc8349 board, but that is the only hardware that I have. I've also > probably made mistakes and it needs to be split up into separate patches, > but this is probabl

[PATCH] net: fix OF fixed-link property handling on Freescale network device drivers

2009-07-03 Thread Grant Likely
From: Grant Likely The MDIO rework patches broke the handling of fixed MII links. This patch adds parsing of the fixed-link property to the gianfar, ucc-geth and fs_eth network drivers, and ensures that the MAC will work without a PHY attachment. Note: This patch does not use the dummy phy appr