Re: [PATCH] net: ethernet: fs-enet: remove casting dma_alloc_coherent

2021-03-16 Thread Christophe Leroy
Le 11/12/2020 à 17:55, David Laight a écrit : From: Christophe Leroy Sent: 11 December 2020 16:43 Le 11/12/2020 à 17:07, David Laight a écrit : From: Christophe Leroy Sent: 11 December 2020 15:22 Le 11/12/2020 à 09:52, Xu Wang a écrit : Remove casting the values returned by dma_alloc_coh

RE: [PATCH] net: ethernet: fs-enet: remove casting dma_alloc_coherent

2020-12-11 Thread David Laight
From: Christophe Leroy > Sent: 11 December 2020 15:22 > > Le 11/12/2020 à 09:52, Xu Wang a écrit : > > Remove casting the values returned by dma_alloc_coherent. > > Can you explain more in the commit log ? > > As far as I can see, dma_alloc_coherent() doesn't return __iomem, and > ring_base mem

RE: [PATCH] net: ethernet: fs-enet: remove casting dma_alloc_coherent

2020-12-11 Thread David Laight
From: Christophe Leroy > Sent: 11 December 2020 16:43 > > Le 11/12/2020 à 17:07, David Laight a écrit : > > From: Christophe Leroy > >> Sent: 11 December 2020 15:22 > >> > >> Le 11/12/2020 à 09:52, Xu Wang a écrit : > >>> Remove casting the values returned by dma_alloc_coherent. > >> > >> Can you

Re: [PATCH] net: ethernet: fs-enet: remove casting dma_alloc_coherent

2020-12-11 Thread Christophe Leroy
Le 11/12/2020 à 17:07, David Laight a écrit : From: Christophe Leroy Sent: 11 December 2020 15:22 Le 11/12/2020 à 09:52, Xu Wang a écrit : Remove casting the values returned by dma_alloc_coherent. Can you explain more in the commit log ? As far as I can see, dma_alloc_coherent() doesn't

Re: [PATCH] net: ethernet: fs-enet: remove casting dma_alloc_coherent

2020-12-11 Thread Christophe Leroy
Le 11/12/2020 à 09:52, Xu Wang a écrit : Remove casting the values returned by dma_alloc_coherent. Can you explain more in the commit log ? As far as I can see, dma_alloc_coherent() doesn't return __iomem, and ring_base member is __iomem Christophe Signed-off-by: Xu Wang --- drivers

[PATCH] net: ethernet: fs-enet: remove casting dma_alloc_coherent

2020-12-11 Thread Xu Wang
Remove casting the values returned by dma_alloc_coherent. Signed-off-by: Xu Wang --- drivers/net/ethernet/freescale/fs_enet/mac-fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fec.c b/drivers/net/ethernet/freescale/fs_enet/mac