> From: Paul Gortmaker <[EMAIL PROTECTED]>
> Date: Fri, 21 Dec 2007 10:12:38 -0500
> Subject: [PATCH] mpc85xx_ads: add in missing of_node_put()
>
> Add in missing of_node_put() after cpm2_pic_init(). This and other coding
> style cleanups as suggested by Stephen Rothwell.
In message: Re: [PATCH] mpc85xx_ads: add in missing of_node_put()
on 23/12/2007 Stephen Rothwell wrote:
> On Fri, 21 Dec 2007 10:40:09 -0500 Paul Gortmaker <[EMAIL PROTECTED]> wrote:
> >
> > cpm2_pic_init() does its own of_node_get() so we should do an of_node_put()
On Fri, 21 Dec 2007 10:40:09 -0500 Paul Gortmaker <[EMAIL PROTECTED]> wrote:
>
> cpm2_pic_init() does its own of_node_get() so we should do an of_node_put()
> before calling it.
The of_node_put() should really go after the call to cpm2_pic_init(), that
way you retain a raised ref count at all time
cpm2_pic_init() does its own of_node_get() so we should do an of_node_put()
before calling it. This and other coding style cleanups as suggested by
Stephen Rothwell.
Signed-off-by: Paul Gortmaker <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/85xx/mpc85xx_ads.c | 12 ++--
1 files change
