Re: [PATCH] mpc5121/clocks: make debug output more readable

2009-05-08 Thread Grant Likely
On Fri, May 8, 2009 at 6:34 AM, Wolfram Sang wrote: > > - Drop KERN_ levels for printks which print to the same line > - use '=' in output to connect key/value pairs Personally, I'd rather see the printks converted to pr_info()/pr_cont(). g. > > Signed-off-by: Wolfram Sang > Cc: John Rigby >

Re: [PATCH] mpc5121/clocks: make debug output more readable

2009-05-08 Thread Geert Uytterhoeven
On Fri, 8 May 2009, Wolfram Sang wrote: > - Drop KERN_ levels for printks which print to the same line Those should use KERN_CONT nowadays. > - use '=' in output to connect key/value pairs > > Signed-off-by: Wolfram Sang > Cc: John Rigby > Cc: Grant Likely > > --- > arch/powerpc/platforms/5

[PATCH] mpc5121/clocks: make debug output more readable

2009-05-08 Thread Wolfram Sang
- Drop KERN_ levels for printks which print to the same line - use '=' in output to connect key/value pairs Signed-off-by: Wolfram Sang Cc: John Rigby Cc: Grant Likely --- arch/powerpc/platforms/512x/clock.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Index: .kernel/arch