Re: [PATCH] mm: fix ENTRIES_PER_PAGEPAGE overflow with 256KB pages

2008-09-11 Thread prodyut hazarika
> On Thu, Sep 11, 2008 at 01:53:07AM +0400, Ilya Yanok wrote: >> ENTRIES_PER_PAGEPAGE define in mm/shmem.c becomes zero if page size is >> 256KB. This patch fixes this. > > This looks.. dubious. You're making a change to generic code for a > powerpc feature. Plus it's not entirely clear that simp

Re: [PATCH] mm: fix ENTRIES_PER_PAGEPAGE overflow with 256KB pages

2008-09-11 Thread David Gibson
On Thu, Sep 11, 2008 at 01:53:07AM +0400, Ilya Yanok wrote: > ENTRIES_PER_PAGEPAGE define in mm/shmem.c becomes zero if page size is > 256KB. This patch fixes this. This looks.. dubious. You're making a change to generic code for a powerpc feature. Plus it's not entirely clear that simply increa

[PATCH] mm: fix ENTRIES_PER_PAGEPAGE overflow with 256KB pages

2008-09-10 Thread Ilya Yanok
ENTRIES_PER_PAGEPAGE define in mm/shmem.c becomes zero if page size is 256KB. This patch fixes this. Signed-off-by: Ilya Yanok <[EMAIL PROTECTED]> --- mm/shmem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 04fb4f1..c603427 100644 ---