On Sun, May 19, 2019 at 1:55 AM Aneesh Kumar K.V
wrote:
>
>
> Hi Dan,
>
> "Aneesh Kumar K.V" writes:
>
> > On 5/17/19 8:19 PM, Vaibhav Jain wrote:
> >> Hi Aneesh,
> >>
>
>
>
> >>
> >>> + /*
> >>> +* Check whether the we support the alignment. For Dax if the
> >>> +* superblock alig
Hi Dan,
"Aneesh Kumar K.V" writes:
> On 5/17/19 8:19 PM, Vaibhav Jain wrote:
>> Hi Aneesh,
>>
>>
>>> + /*
>>> +* Check whether the we support the alignment. For Dax if the
>>> +* superblock alignment is not matching, we won't initialize
>>> +* the device.
>>> +*/
>>>
On 5/17/19 8:19 PM, Vaibhav Jain wrote:
Hi Aneesh,
Apart from a minor review comment for changes to nd_pfn_validate() the
patch looks good to me.
Also, I Tested this patch on a PPC64 qemu guest with virtual nvdimm and
verified that default alignment of newly created devdax namespace was
64KiB i
Hi Aneesh,
Apart from a minor review comment for changes to nd_pfn_validate() the
patch looks good to me.
Also, I Tested this patch on a PPC64 qemu guest with virtual nvdimm and
verified that default alignment of newly created devdax namespace was
64KiB instead of 16MiB. Below are the test result
Allow arch to provide the supported alignments and use hugepage alignment only
if we support hugepage. Right now we depend on compile time configs whereas this
patch switch this to runtime discovery.
Architectures like ppc64 can have THP enabled in code, but then can have
hugepage size disabled by
