Re: [PATCH] misc: ocxl: fix possible name leak in ocxl_file_register_afu()

2022-11-30 Thread Michael Ellerman
On Fri, 11 Nov 2022 22:59:29 +0800, Yang Yingliang wrote: > If device_register() returns error in ocxl_file_register_afu(), > the name allocated by dev_set_name() need be freed. As comment > of device_register() says, it should use put_device() to give > up the reference in the error path. So fix t

Re: [PATCH] misc: ocxl: fix possible name leak in ocxl_file_register_afu()

2022-11-20 Thread Andrew Donnellan
On Fri, 2022-11-11 at 22:59 +0800, Yang Yingliang wrote: > If device_register() returns error in ocxl_file_register_afu(), > the name allocated by dev_set_name() need be freed. As comment > of device_register() says, it should use put_device() to give > up the reference in the error path. So fix th

Re: [PATCH] misc: ocxl: fix possible name leak in ocxl_file_register_afu()

2022-11-14 Thread Frederic Barrat
On 14/11/2022 12:46, Yang Yingliang wrote: Hi, On 2022/11/14 19:23, Frederic Barrat wrote: On 11/11/2022 15:59, Yang Yingliang wrote: If device_register() returns error in ocxl_file_register_afu(), the name allocated by dev_set_name() need be freed. As comment of device_register() says, i

Re: [PATCH] misc: ocxl: fix possible name leak in ocxl_file_register_afu()

2022-11-14 Thread Yang Yingliang
Hi, On 2022/11/14 19:23, Frederic Barrat wrote: On 11/11/2022 15:59, Yang Yingliang wrote: If device_register() returns error in ocxl_file_register_afu(), the name allocated by dev_set_name() need be freed. As comment of device_register() says, it should use put_device() to give up the refere

Re: [PATCH] misc: ocxl: fix possible name leak in ocxl_file_register_afu()

2022-11-14 Thread Frederic Barrat
On 11/11/2022 15:59, Yang Yingliang wrote: If device_register() returns error in ocxl_file_register_afu(), the name allocated by dev_set_name() need be freed. As comment of device_register() says, it should use put_device() to give up the reference in the error path. So fix this by calling put

[PATCH] misc: ocxl: fix possible name leak in ocxl_file_register_afu()

2022-11-11 Thread Yang Yingliang
If device_register() returns error in ocxl_file_register_afu(), the name allocated by dev_set_name() need be freed. As comment of device_register() says, it should use put_device() to give up the reference in the error path. So fix this by calling put_device(), then the name can be freed in kobject