Re: [PATCH] macintosh/ams: linux/platform_device.h is needed

2023-08-31 Thread Michael Ellerman
On Tue, 29 Aug 2023 15:58:37 -0700, Randy Dunlap wrote: > ams.h uses struct platform_device, so the header should be used > to prevent build errors: > > drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable': > drivers/macintosh/ams/ams-input.c:68:45: error: invalid use of undefined typ

Re: [PATCH] macintosh/ams: linux/platform_device.h is needed

2023-08-30 Thread Randy Dunlap
Hi, On 8/29/23 22:46, Christophe Leroy wrote: > > > Le 30/08/2023 à 00:58, Randy Dunlap a écrit : >> ams.h uses struct platform_device, so the header should be used >> to prevent build errors: >> >> drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable': >> drivers/macintosh/ams/ams-i

Re: [PATCH] macintosh/ams: linux/platform_device.h is needed

2023-08-29 Thread Christophe Leroy
Le 30/08/2023 à 00:58, Randy Dunlap a écrit : > ams.h uses struct platform_device, so the header should be used > to prevent build errors: > > drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable': > drivers/macintosh/ams/ams-input.c:68:45: error: invalid use of undefined type > 'st

[PATCH] macintosh/ams: linux/platform_device.h is needed

2023-08-29 Thread Randy Dunlap
ams.h uses struct platform_device, so the header should be used to prevent build errors: drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable': drivers/macintosh/ams/ams-input.c:68:45: error: invalid use of undefined type 'struct platform_device' 68 | input->dev.parent = &a