Re: [PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

2022-09-17 Thread Wolfram Sang
On Fri, Sep 16, 2022 at 11:08:02AM +0200, Uwe Kleine-König wrote: > Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed > the prototype of ams_i2c_remove() but failed to adapt the declaration. > Catch up and fix the declaration accordingly. > > Fixes: ed5c2f5fd10d ("i2c: Make rem

Re: [PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

2022-09-16 Thread Michael Ellerman
Wolfram Sang writes: >> I don't know how to proceed with this fix. Squashing into the broken >> commit is out of the game as the commit is on a stable branch that is >> already merged in a few trees. Maybe let it go in via the i2c tree? > > I think it would be simplest if I put it on top of my for

Re: [PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

2022-09-16 Thread Wolfram Sang
> I don't know how to proceed with this fix. Squashing into the broken > commit is out of the game as the commit is on a stable branch that is > already merged in a few trees. Maybe let it go in via the i2c tree? I think it would be simplest if I put it on top of my for-next branch. The other opt

[PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

2022-09-16 Thread Uwe Kleine-König
Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed the prototype of ams_i2c_remove() but failed to adapt the declaration. Catch up and fix the declaration accordingly. Fixes: ed5c2f5fd10d ("i2c: Make remove callback return void") Reported-by: kernel test robot Signed-off-by: Uw