Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-27 Thread Michael Ellerman
Peter Zijlstra writes: > On Mon, Oct 25, 2021 at 03:06:24PM +0200, Arnd Bergmann wrote: >> On Mon, Oct 25, 2021 at 11:57 AM Peter Zijlstra wrote: >> > On Sat, Oct 23, 2021 at 06:04:57PM +0200, Arnd Bergmann wrote: >> > > On Sat, Oct 23, 2021 at 3:37 AM Waiman Long wrote: >> > > >> On 10/22/21 7:

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-25 Thread Waiman Long
On 10/25/21 11:44 AM, Arnd Bergmann wrote: On Mon, Oct 25, 2021 at 5:28 PM Waiman Long wrote: On 10/25/21 9:06 AM, Arnd Bergmann wrote: On s390, we pick between the cmpxchg() based directed-yield when running on virtualized CPUs, and a normal qspinlock when running on a dedicated CPU. I am no

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-25 Thread Arnd Bergmann
On Mon, Oct 25, 2021 at 5:28 PM Waiman Long wrote: > On 10/25/21 9:06 AM, Arnd Bergmann wrote: > > > > On s390, we pick between the cmpxchg() based directed-yield when > > running on virtualized CPUs, and a normal qspinlock when running on a > > dedicated CPU. > > I am not aware that s390 is using

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-25 Thread Waiman Long
On 10/25/21 9:06 AM, Arnd Bergmann wrote: On Mon, Oct 25, 2021 at 11:57 AM Peter Zijlstra wrote: On Sat, Oct 23, 2021 at 06:04:57PM +0200, Arnd Bergmann wrote: On Sat, Oct 23, 2021 at 3:37 AM Waiman Long wrote: On 10/22/21 7:59 AM, Arnd Bergmann wrote: From: Arnd Bergmann As this is all

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-25 Thread Peter Zijlstra
On Mon, Oct 25, 2021 at 03:06:24PM +0200, Arnd Bergmann wrote: > On Mon, Oct 25, 2021 at 11:57 AM Peter Zijlstra wrote: > > On Sat, Oct 23, 2021 at 06:04:57PM +0200, Arnd Bergmann wrote: > > > On Sat, Oct 23, 2021 at 3:37 AM Waiman Long wrote: > > > >> On 10/22/21 7:59 AM, Arnd Bergmann wrote: >

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-25 Thread Arnd Bergmann
On Mon, Oct 25, 2021 at 11:57 AM Peter Zijlstra wrote: > On Sat, Oct 23, 2021 at 06:04:57PM +0200, Arnd Bergmann wrote: > > On Sat, Oct 23, 2021 at 3:37 AM Waiman Long wrote: > > >> On 10/22/21 7:59 AM, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > As this is all dead code, ju

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-25 Thread Peter Zijlstra
On Mon, Oct 25, 2021 at 11:57:28AM +0200, Peter Zijlstra wrote: > On Sat, Oct 23, 2021 at 06:04:57PM +0200, Arnd Bergmann wrote: > > On Sat, Oct 23, 2021 at 3:37 AM Waiman Long wrote: > > >> On 10/22/21 7:59 AM, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > As this is all dead

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-25 Thread Peter Zijlstra
On Sat, Oct 23, 2021 at 06:04:57PM +0200, Arnd Bergmann wrote: > On Sat, Oct 23, 2021 at 3:37 AM Waiman Long wrote: > >> On 10/22/21 7:59 AM, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > As this is all dead code, just remove it and the helper functions built > > > around it. For arc

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-23 Thread Arnd Bergmann
On Sat, Oct 23, 2021 at 3:37 AM Waiman Long wrote: >> On 10/22/21 7:59 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > As this is all dead code, just remove it and the helper functions built > > around it. For arch/ia64, the inline asm could be cleaned up, but > > it seems safer to leave

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-22 Thread Waiman Long
On 10/22/21 7:59 AM, Arnd Bergmann wrote: From: Arnd Bergmann parisc, ia64 and powerpc32 are the only remaining architectures that provide custom arch_{spin,read,write}_lock_flags() functions, which are meant to re-enable interrupts while waiting for a spinlock. However, none of these can actu

Re: [PATCH] locking: remove spin_lock_flags() etc

2021-10-22 Thread Helge Deller
On 10/22/21 13:59, Arnd Bergmann wrote: > From: Arnd Bergmann > > parisc, ia64 and powerpc32 are the only remaining architectures that > provide custom arch_{spin,read,write}_lock_flags() functions, which are > meant to re-enable interrupts while waiting for a spinlock. > > However, none of these

[PATCH] locking: remove spin_lock_flags() etc

2021-10-22 Thread Arnd Bergmann
From: Arnd Bergmann parisc, ia64 and powerpc32 are the only remaining architectures that provide custom arch_{spin,read,write}_lock_flags() functions, which are meant to re-enable interrupts while waiting for a spinlock. However, none of these can actually run into this codepath, because it is o