Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-09 Thread Michael Ellerman
Andy Shevchenko writes: > On Thu, 2018-08-09 at 16:18 +1000, Michael Ellerman wrote: >> rashmica writes: >> > On 08/08/18 17:25, Michael Ellerman wrote: >> > > Christophe Leroy writes: >> > > > >> > mpe I sent a patch doing that awhile ago and you obviously didn't >> > like >> > it because you

Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-09 Thread Andy Shevchenko
On Thu, 2018-08-09 at 16:18 +1000, Michael Ellerman wrote: > rashmica writes: > > On 08/08/18 17:25, Michael Ellerman wrote: > > > Christophe Leroy writes: > > > > > > mpe I sent a patch doing that awhile ago and you obviously didn't > > like > > it because you never merged it :P Hmm... I (as a

Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-08 Thread Michael Ellerman
rashmica writes: > On 08/08/18 17:25, Michael Ellerman wrote: >> Christophe Leroy writes: >>> diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c >>> index 3f415d8101f3..626f580b4ff7 100644 >>> --- a/lib/test_hexdump.c >>> +++ b/lib/test_hexdump.c >>> @@ -32,16 +32,33 @@ static const char * cons

Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-08 Thread rashmica
On 08/08/18 17:25, Michael Ellerman wrote: > Christophe Leroy writes: >> diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c >> index 3f415d8101f3..626f580b4ff7 100644 >> --- a/lib/test_hexdump.c >> +++ b/lib/test_hexdump.c >> @@ -32,16 +32,33 @@ static const char * const test_data_2_le[] __in

Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-08 Thread Andy Shevchenko
On Wed, 2018-08-08 at 06:37 +, Christophe Leroy wrote: > On a big endian cpu, test_hexdump fails as follows. The logs show > that bytes are expected in reversed order. > > [...] > [ 16.643648] test_hexdump: Len: 24 buflen: 130 strlen: 97 > [ 16.648681] test_hexdump: Result: 97 'be32db7b 0a

Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-08 Thread Christophe LEROY
Le 08/08/2018 à 09:25, Michael Ellerman a écrit : Christophe Leroy writes: diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c index 3f415d8101f3..626f580b4ff7 100644 --- a/lib/test_hexdump.c +++ b/lib/test_hexdump.c @@ -32,16 +32,33 @@ static const char * const test_data_2_le[] __initconst

Re: [PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-08 Thread Michael Ellerman
Christophe Leroy writes: > diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c > index 3f415d8101f3..626f580b4ff7 100644 > --- a/lib/test_hexdump.c > +++ b/lib/test_hexdump.c > @@ -32,16 +32,33 @@ static const char * const test_data_2_le[] __initconst = { > "d14c", "9919", "b143", "0caf", >

[PATCH] lib/test_hexdump: fix failure on big endian cpu

2018-08-07 Thread Christophe Leroy
On a big endian cpu, test_hexdump fails as follows. The logs show that bytes are expected in reversed order. [...] [ 16.643648] test_hexdump: Len: 24 buflen: 130 strlen: 97 [ 16.648681] test_hexdump: Result: 97 'be32db7b 0a1893b2 70bac424 7d83349b a69c31ad 9c0face9.2.{