Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init

2025-04-17 Thread Eric Biggers
On Thu, Apr 17, 2025 at 02:53:18PM +0200, Heiko Carstens wrote: > On Sun, Apr 13, 2025 at 08:43:50AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > All of the CRC library's CPU feature static_keys are initialized by > > initcalls and never change afterwards, so there's no need for them

Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init

2025-04-17 Thread Heiko Carstens
On Sun, Apr 13, 2025 at 08:43:50AM -0700, Eric Biggers wrote: > From: Eric Biggers > > All of the CRC library's CPU feature static_keys are initialized by > initcalls and never change afterwards, so there's no need for them to be > in the regular .data section. Put them in .data..ro_after_init i

Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init

2025-04-14 Thread Martin K. Petersen
Eric, > All of the CRC library's CPU feature static_keys are initialized by > initcalls and never change afterwards, so there's no need for them to > be in the regular .data section. Put them in .data..ro_after_init > instead. LGTM. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init

2025-04-14 Thread Ard Biesheuvel
On Sun, 13 Apr 2025 at 17:44, Eric Biggers wrote: > > From: Eric Biggers > > All of the CRC library's CPU feature static_keys are initialized by > initcalls and never change afterwards, so there's no need for them to be > in the regular .data section. Put them in .data..ro_after_init instead. >

[PATCH] lib/crc: make the CPU feature static keys __ro_after_init

2025-04-13 Thread Eric Biggers
From: Eric Biggers All of the CRC library's CPU feature static_keys are initialized by initcalls and never change afterwards, so there's no need for them to be in the regular .data section. Put them in .data..ro_after_init instead. Signed-off-by: Eric Biggers --- I'm planning to take this via