Re: [PATCH] leds: powernv: add of_node_put()

2018-11-21 Thread Frank Lee
On Thu, Nov 22, 2018 at 4:45 AM Jacek Anaszewski wrote: > > Hi Yangtao, > > Thank you for the patch. > > On 11/21/2018 01:31 PM, Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node returned by > > it and that reference needs to be dropped by its caller.bl_idle_init() > >

Re: [PATCH] leds: powernv: add of_node_put()

2018-11-21 Thread Jacek Anaszewski
Hi Yangtao, Thank you for the patch. On 11/21/2018 01:31 PM, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node returned by > it and that reference needs to be dropped by its caller.bl_idle_init() > doesn't do that, so fix it. s/bl_idle_init/powernv_led_probe/ I suppose

[PATCH] leds: powernv: add of_node_put()

2018-11-21 Thread Yangtao Li
of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller.bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li --- drivers/leds/leds-powernv.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) dif