Re: [PATCH] kvm/powerpc: Handle errors in secondary thread grabbing

2012-10-16 Thread Alexander Graf
On 16.10.2012, at 21:33, Benjamin Herrenschmidt wrote: > On Tue, 2012-10-16 at 17:00 +1100, Michael Ellerman wrote: >>> Thanks for looking at this - but in fact this is fixed by my patch >>> entitled "KVM: PPC: Book3S HV: Fix some races in starting secondary >>> threads" submitted back on August

Re: [PATCH] kvm/powerpc: Handle errors in secondary thread grabbing

2012-10-16 Thread Benjamin Herrenschmidt
On Tue, 2012-10-16 at 17:00 +1100, Michael Ellerman wrote: > > Thanks for looking at this - but in fact this is fixed by my patch > > entitled "KVM: PPC: Book3S HV: Fix some races in starting secondary > > threads" submitted back on August 28. > > OK thanks. It seems that patch didn't make 3.7 ? >

Re: [PATCH] kvm/powerpc: Handle errors in secondary thread grabbing

2012-10-15 Thread Michael Ellerman
On Tue, 2012-10-16 at 14:13 +1100, Paul Mackerras wrote: > Michael, > > On Tue, Oct 16, 2012 at 11:15:50AM +1100, Michael Ellerman wrote: > > In the Book3s HV code, kvmppc_run_core() has logic to grab the secondary > > threads of the physical core. > > > > If for some reason a thread is stuck, kv

Re: [PATCH] kvm/powerpc: Handle errors in secondary thread grabbing

2012-10-15 Thread Paul Mackerras
Michael, On Tue, Oct 16, 2012 at 11:15:50AM +1100, Michael Ellerman wrote: > In the Book3s HV code, kvmppc_run_core() has logic to grab the secondary > threads of the physical core. > > If for some reason a thread is stuck, kvmppc_grab_hwthread() can fail, > but currently we ignore the failure an

[PATCH] kvm/powerpc: Handle errors in secondary thread grabbing

2012-10-15 Thread Michael Ellerman
In the Book3s HV code, kvmppc_run_core() has logic to grab the secondary threads of the physical core. If for some reason a thread is stuck, kvmppc_grab_hwthread() can fail, but currently we ignore the failure and continue into the guest. If the stuck thread is in the kernel badness ensues. Inste