Re: [PATCH] kill useless SMT code in prom_hold_cpus

2008-07-14 Thread Benjamin Herrenschmidt
On Mon, 2008-07-14 at 21:24 -0500, Nathan Lynch wrote: > Benjamin Herrenschmidt wrote: > > On Tue, 2008-07-08 at 17:36 -0500, Nathan Lynch wrote: > > > I think this code that counts SMT threads and compares against NR_CPUS > > > is an artifact of pre-powerpc-merge ppc64. We care about starting > >

Re: [PATCH] kill useless SMT code in prom_hold_cpus

2008-07-14 Thread Tony Breeds
On Mon, Jul 14, 2008 at 11:55:51PM -0500, Nathan Lynch wrote: > sysfs. (e.g. /sys/devices/system/cpu/cpu0/physical_id) Hmm okay, sysfs is fine if you're gettign all the way up. I guess if we have problems in that are we can readd the printf(). > The proper place for such a message is in the k

Re: [PATCH] kill useless SMT code in prom_hold_cpus

2008-07-14 Thread Nathan Lynch
Tony Breeds wrote: > On Tue, Jul 08, 2008 at 05:36:31PM -0500, Nathan Lynch wrote: > > > - prom_printf("%x : starting cpu hw idx %x... ", cpuid, > > reg); > > + prom_printf("starting cpu hw idx %x... ", reg); > > If we remove this, where else can we see the ma

Re: [PATCH] kill useless SMT code in prom_hold_cpus

2008-07-14 Thread Nathan Lynch
Benjamin Herrenschmidt wrote: > On Tue, 2008-07-08 at 17:36 -0500, Nathan Lynch wrote: > > I think this code that counts SMT threads and compares against NR_CPUS > > is an artifact of pre-powerpc-merge ppc64. We care about starting > > only primary threads in the OF client code. > > > > Signed-of

Re: [PATCH] kill useless SMT code in prom_hold_cpus

2008-07-14 Thread Tony Breeds
On Tue, Jul 08, 2008 at 05:36:31PM -0500, Nathan Lynch wrote: > I think this code that counts SMT threads and compares against NR_CPUS > is an artifact of pre-powerpc-merge ppc64. We care about starting > only primary threads in the OF client code. > - prom_printf("%x : star

Re: [PATCH] kill useless SMT code in prom_hold_cpus

2008-07-14 Thread Benjamin Herrenschmidt
On Tue, 2008-07-08 at 17:36 -0500, Nathan Lynch wrote: > I think this code that counts SMT threads and compares against NR_CPUS > is an artifact of pre-powerpc-merge ppc64. We care about starting > only primary threads in the OF client code. > > Signed-off-by: Nathan Lynch <[EMAIL PROTECTED]> Th

[PATCH] kill useless SMT code in prom_hold_cpus

2008-07-08 Thread Nathan Lynch
I think this code that counts SMT threads and compares against NR_CPUS is an artifact of pre-powerpc-merge ppc64. We care about starting only primary threads in the OF client code. Signed-off-by: Nathan Lynch <[EMAIL PROTECTED]> --- arch/powerpc/kernel/prom_init.c | 39 +++-