Re: [PATCH] ide: make ide_pci_check_iomem() actually work

2008-04-15 Thread Bartlomiej Zolnierkiewicz
On Wednesday 09 April 2008, Bartlomiej Zolnierkiewicz wrote: > > [ added Akira & Kou to cc: ] > > On Tuesday 08 April 2008, Sergei Shtylyov wrote: > > Hi, I just wrote: > > > > >>> This function didn't actually check if a given BAR is in I/O space > > >>> because of > > >>> using the bogus PCI_

Re: [PATCH] ide: make ide_pci_check_iomem() actually work

2008-04-09 Thread Bartlomiej Zolnierkiewicz
[ added Akira & Kou to cc: ] On Tuesday 08 April 2008, Sergei Shtylyov wrote: > Hi, I just wrote: > > >>> This function didn't actually check if a given BAR is in I/O space > >>> because of > >>> using the bogus PCI_BASE_ADDRESS_IO_MASK (which equals ~3) to test > >>> the resource > >>> flags

Re: [PATCH] ide: make ide_pci_check_iomem() actually work

2008-04-08 Thread Sergei Shtylyov
Hi, I just wrote: This function didn't actually check if a given BAR is in I/O space because of using the bogus PCI_BASE_ADDRESS_IO_MASK (which equals ~3) to test the resource flags instead of IORESOURCE_IO -- fix this, make ide_hwif_configure() check the results failing if necessary, and move