Re: [PATCH] ibm_newemac: Fixes entry of short packets

2008-06-27 Thread Benjamin Herrenschmidt
> > > Actually , short packets are not allowed to flow through the higher > layers, If any of the layer tried to use the extra room available may > hit wit crash . > Since it is a invalid packet it has to be dropped and freed in driver. > Actually if you see in code, the other invalid pa

Re: [PATCH] ibm_newemac: Fixes entry of short packets

2008-06-27 Thread SathyaNarayanan
Hi benh, Please find my comments inline. On Tue, Jun 24, 2008 at 4:50 AM, Benjamin Herrenschmidt < [EMAIL PROTECTED]> wrote: > On Mon, 2008-06-23 at 14:55 +0200, Stefan Roese wrote: > > From: Sathya Narayanan <[EMAIL PROTECTED]> > > > > Short packets has to be discarded by the driver

Re: [PATCH] ibm_newemac: Fixes entry of short packets

2008-06-23 Thread Benjamin Herrenschmidt
On Mon, 2008-06-23 at 14:55 +0200, Stefan Roese wrote: > From: Sathya Narayanan <[EMAIL PROTECTED]> > > Short packets has to be discarded by the driver. So this patch addresses the > issue of discarding the short packets of size lesser then ethernet header > size. You are freeing the skb, why ? S

[PATCH] ibm_newemac: Fixes entry of short packets

2008-06-23 Thread Stefan Roese
From: Sathya Narayanan <[EMAIL PROTECTED]> Short packets has to be discarded by the driver. So this patch addresses the issue of discarding the short packets of size lesser then ethernet header size. Signed-off-by: Sathya Narayanan <[EMAIL PROTECTED]> Signed-off-by: Stefan Roese <[EMAIL PROTECTED