Re: [PATCH] ibm_newemac: Fix possible lockup on close

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > It's a bad idea to call flush_scheduled_work from within a > netdev->stop because the linkwatch will occasionally take the > rtnl lock from a workqueue context, and thus that can deadlock. > > This reworks things a bit in that area to avoid the problem. > > Signed-

[PATCH] ibm_newemac: Fix possible lockup on close

2007-11-19 Thread Benjamin Herrenschmidt
It's a bad idea to call flush_scheduled_work from within a netdev->stop because the linkwatch will occasionally take the rtnl lock from a workqueue context, and thus that can deadlock. This reworks things a bit in that area to avoid the problem. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTE