Re: [PATCH] ibm_newemac: Fix new MAL feature handling

2008-10-20 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Thu, 2008-10-16 at 10:38 -0400, Josh Boyer wrote: On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote: drivers/net/ibm_newemac/mal.c: In function 'mal_txeob': drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function 'mtdcri'

Re: [PATCH] ibm_newemac: Fix new MAL feature handling

2008-10-20 Thread Benjamin Herrenschmidt
On Thu, 2008-10-16 at 10:38 -0400, Josh Boyer wrote: > On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote: > >> drivers/net/ibm_newemac/mal.c: In function 'mal_txeob': > >> drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function > >> 'mtdcri' > >> drivers/net

Re: [PATCH] ibm_newemac: Fix new MAL feature handling

2008-10-17 Thread Josh Boyer
On Fri, 17 Oct 2008 14:56:52 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Thursday 16 October 2008, Josh Boyer wrote: > > +#ifdef CONFIG_PPC_DCR_NATIVE > > if (mal_has_feature(mal, MAL_FTR_CLEAR_ICINTSTAT)) > > mtdcri(SDR0, DCRN_SDR_ICINTSTAT, > >    

Re: [PATCH] ibm_newemac: Fix new MAL feature handling

2008-10-17 Thread Arnd Bergmann
On Thursday 16 October 2008, Josh Boyer wrote: > +#ifdef CONFIG_PPC_DCR_NATIVE > if (mal_has_feature(mal, MAL_FTR_CLEAR_ICINTSTAT)) > mtdcri(SDR0, DCRN_SDR_ICINTSTAT, > (mfdcri(SDR0, DCRN_SDR_ICINTSTAT) | > ICINTSTAT_ICTX)); > +#endif >   So

[PATCH] ibm_newemac: Fix new MAL feature handling

2008-10-16 Thread Josh Boyer
On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote: >> drivers/net/ibm_newemac/mal.c: In function 'mal_txeob': >> drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function >> 'mtdcri' >> drivers/net/ibm_newemac/mal.c:284: error: 'SDR0' undeclared (first use in